added the group id to config file and added more info to the async pr…

…ocessing comment
Real-Dev-Squad · Nov 11, 2024 · 7cc0e36 · 7cc0e36
1 parent dd153f3
commit 7cc0e36
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/config/config.ts b/config/config.ts
@@ -56,6 +56,9 @@ export function loadEnv(env: env, fromWorkerEnv: boolean): env {
     IDENTITY_SERVICE_PUBLIC_KEY: fromWorkerEnv
       ? env.IDENTITY_SERVICE_PUBLIC_KEY
       : process.env.IDENTITY_SERVICE_PUBLIC_KEY || "",
+    AWS_READ_ACCESS_GROUP_ID: fromWorkerEnv
+      ? env.AWS_READ_ACCESS_GROUP_ID
+      : process.env.AWS_READ_ACCESS_GROUP_ID || "",
   };
   return Env;
 }

diff --git a/src/constants/commands.ts b/src/constants/commands.ts
@@ -1,7 +1,3 @@
-import { config } from "dotenv";
-
-config();
-
 export const HELLO = {
   name: "hello",
   description: "Replies with hello in the channel",
@@ -49,7 +45,7 @@ export const GRANT_AWS_ACCESS = {
       choices: [
         {
           name: "AWS read access",
-          value: process.env.AWS_read_access_group_id,
+          value: process.env.AWS_READ_ACCESS_GROUP_ID,
         },
       ],
     },

diff --git a/src/utils/awsAccess.ts b/src/utils/awsAccess.ts
@@ -83,7 +83,7 @@ export async function grantAWSAccess(
   ctx: ExecutionContext,
   channelId: number
 ) {
-  // Immediately send a Discord response to acknowledge the command
+  // Immediately send a Discord response to acknowledge the command, as the cloudfare workers have a limit of response time equals to 3s
   const initialResponse = discordTextResponse(
     `<@${discordUserId}> Processing your request to grant AWS access.`
   );