This repository has been archived by the owner on Oct 1, 2018. It is now read-only.
fix(operators): disable esc key closing of nested operator sidenav #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only disables close via esc when larger than a small screen Closes Issue #255 Bug: Escape closes Sidebar
|
@jwo719 could you review please? |
Codecov Report
@@ Coverage Diff @@
## master #275 +/- ##
========================================
Coverage ? 79.9%
========================================
Files ? 17
Lines ? 214
Branches ? 9
========================================
Hits ? 171
Misses ? 41
Partials ? 2Continue to review full report at Codecov.
|
|
Closing this PR and finishing the UX discussion brought up in #255 @knittingcodemonkey brought up that closing of the nested sidenav is intentional. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only disables close via esc when larger than a small screen
Closes Issue #255 Bug: Escape closes Sidebar