This repository has been archived by the owner on Oct 1, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 62
feat(operators): add searchbar #264
Closed
Closed
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
dd69e6c
feat(operators): add searchbar
a38b568
fix(searchbar): fix build
niklas-wortmann c075d77
Merge branch 'master' of github.com:ReactiveX/rxjs-docs into add-sear…
ae97da1
Merge branch 'add-searchbar' of github.com:JWO719/rxjs-docs into add-…
5be2a24
Merge branch 'master' into add-searchbar
niklas-wortmann b883fa4
docs(operators): change searchbar the rxjs way
4a18443
Merge branch 'master' of github.com:ReactiveX/rxjs-docs into add-sear…
7734bad
Merge branch 'add-searchbar' of github.com:JWO719/rxjs-docs into add-…
141c3e1
docs(operators): remove unused imports
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -27,3 +27,9 @@ $subheader-color: #333; | |
bottom: 10px; | ||
z-index: 4; | ||
} | ||
|
||
.full-width-form{ | ||
width: 95%; | ||
height: 48px; | ||
padding: 6px; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,6 +21,7 @@ import { WalkthroughComponent } from './components/walkthrough/walkthrough.compo | |
import { HighlightJsDirective } from './directives/highlight-js.directive'; | ||
import { SafeUrlPipe } from './pipes/safe-url.pipe'; | ||
import { MaterialModule } from '../material/material.module'; | ||
import { FormsModule, ReactiveFormsModule } from '@angular/forms'; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think the import of BTW, could we keep a consistent import style? Maybe the one explained in the angular style guide |
||
|
||
@NgModule({ | ||
declarations: [ | ||
|
@@ -42,6 +43,8 @@ import { MaterialModule } from '../material/material.module'; | |
MaterialModule, | ||
OperatorsRoutingModule, | ||
LayoutModule, | ||
FormsModule, | ||
ReactiveFormsModule, | ||
TranslateModule | ||
], | ||
providers: [ | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Considering that this input is model driven and not template drive, could you move the value initialization of the
formControl
into the component? IMO is cleaner to not mix template/model driven when possible.