Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extension method toSingle #230

Closed
wants to merge 2 commits into from
Closed

Add extension method toSingle #230

wants to merge 2 commits into from

Conversation

VovaStelmashchuk
Copy link

  1. Add extension method toSingle for create a Single from object. Like an Observable from Collections.
  2. Small code reformation.

@vpriscan
Copy link
Collaborator

Hi @jordan1997, you should pull upstream 2.x branch again to apply the fix for Travis build, there was a problem with JDK version (oraclejdk8 license was changed and it stopped working).

@VovaStelmashchuk
Copy link
Author

@vpriscan Done.

@vpriscan
Copy link
Collaborator

@jordan1997 Thanks. The build is now passing. But I forgot to say, you should now target the new RxKotlin 3.x version. Version 2.x is now in maintenance mode, meaning no new features will be accepted.

@VovaStelmashchuk
Copy link
Author

VovaStelmashchuk commented Mar 22, 2020

I cherry-pick my commit to 3.x, and create a new PR #231 , because i can change the source branch of exists PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants