@LoopBinding and @EnvironmentLoop for SwiftUI. #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergdort
reviewed
May 18, 2020
sergdort
reviewed
May 18, 2020
|
|
||
| public func send(_ event: Event) { | ||
| loop.send(event) | ||
| } |
There was a problem hiding this comment.
shall we extend this to also have binding(for: KeyPath<State, V>, event: Event) -> Binding<V>?
There was a problem hiding this comment.
this is an additive functionality that needs more thoughts, esp conversion/relationship of the KeyPaths and Event.
There was a problem hiding this comment.
well the common use case I guess is showing the sheet which requires an optional binding that drives presentation of the sheet
sergdort
reviewed
May 18, 2020
sergdort
reviewed
May 18, 2020
sergdort
reviewed
May 18, 2020
sergdort
reviewed
May 18, 2020
sergdort
requested changes
May 18, 2020
sergdort
approved these changes
May 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce two property wrappers,
@LoopBindingand@EnvironmentLoop, for SwiftUI integration as described in #2.Two simple stepper examples are added to validate the concepts. They shall be replaced with more elaborate examples.