Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comparison to other packages #162

Merged
merged 11 commits into from
Nov 1, 2023
Merged

Add comparison to other packages #162

merged 11 commits into from
Nov 1, 2023

Conversation

albertpod
Copy link
Member

This PR addresses #71

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (215f458) 81.03% compared to head (2e049a3) 81.03%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #162   +/-   ##
=======================================
  Coverage   81.03%   81.03%           
=======================================
  Files          11       11           
  Lines        1271     1271           
=======================================
  Hits         1030     1030           
  Misses        241      241           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@albertpod
Copy link
Member Author

albertpod commented Oct 20, 2023

@HoangMHNguyen made a few changes. Something occurred to me. Instead of binary table, perhaps we can make a ternary table.

For example, RxInfer is not universal compared to Turing, but it's more universal compared to ForneyLab or PGMax.

WDYT?

@HoangMHNguyen
Copy link
Contributor

HoangMHNguyen commented Oct 20, 2023

@albertpod I think that's a good idea, but we can just write an extra note below the table instead of creating a new table.

(Date of creation: 20/10/2023)

**Notes**:
- **Universality**: Denotes the capability to depict a vast array of probabilistic models.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that PR is not yet ready for review and part of it was probably auto-generated, but please remove all strange and complicated words and use something simple. These text is aimed for non-native speakers, how often do you encounter words such as "sluggishness", "amalgamating", "prowess", "succinctly". Have no idea what do these mean. Most of the text is written in such a manner and this is unreadable for a non-native.

@albertpod
Copy link
Member Author

@albertpod I think that's a good idea, but we can just write an extra note below the table instead of creating a new table.

@HoangMHNguyen perhaps we can use ~ symbol to denote partial capability?
Something like:
: Full capability or feature is present.
~ : Partial capability or feature is present.
: No capability or feature.

@HoangMHNguyen
Copy link
Contributor

Yes, that's even a better idea

@HoangMHNguyen HoangMHNguyen marked this pull request as ready for review October 23, 2023 14:12
@bvdmitri
Copy link
Member

That is the status of this PR? Can it be reviewed and merged potentially? (Sorry if I missed smth, just trying to catch up after my sickness)

@bvdmitri
Copy link
Member

bvdmitri commented Nov 1, 2023

@HoangMHNguyen @albertpod is this ready?

@albertpod
Copy link
Member Author

@bvdmitri yes

@bvdmitri
Copy link
Member

bvdmitri commented Nov 1, 2023

Great, I skimmed through it, looks good to me! Thanks guys!!

@bvdmitri bvdmitri merged commit 519a86d into main Nov 1, 2023
8 checks passed
@bvdmitri bvdmitri deleted the rx-compare-docs branch November 1, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants