-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add comparison to other packages #162
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #162 +/- ##
=======================================
Coverage 81.03% 81.03%
=======================================
Files 11 11
Lines 1271 1271
=======================================
Hits 1030 1030
Misses 241 241 ☔ View full report in Codecov by Sentry. |
@HoangMHNguyen made a few changes. Something occurred to me. Instead of binary table, perhaps we can make a ternary table. For example, RxInfer is not universal compared to Turing, but it's more universal compared to ForneyLab or PGMax. WDYT? |
@albertpod I think that's a good idea, but we can just write an extra note below the table instead of creating a new table. |
(Date of creation: 20/10/2023) | ||
|
||
**Notes**: | ||
- **Universality**: Denotes the capability to depict a vast array of probabilistic models. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand that PR is not yet ready for review and part of it was probably auto-generated, but please remove all strange and complicated words and use something simple. These text is aimed for non-native speakers, how often do you encounter words such as "sluggishness", "amalgamating", "prowess", "succinctly". Have no idea what do these mean. Most of the text is written in such a manner and this is unreadable for a non-native.
@HoangMHNguyen perhaps we can use |
Yes, that's even a better idea |
That is the status of this PR? Can it be reviewed and merged potentially? (Sorry if I missed smth, just trying to catch up after my sickness) |
@HoangMHNguyen @albertpod is this ready? |
@bvdmitri yes |
Great, I skimmed through it, looks good to me! Thanks guys!! |
This PR addresses #71