Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Merge branch dev to main #4123

Merged
merged 14 commits into from
Dec 16, 2024
Merged

chore: Merge branch dev to main #4123

merged 14 commits into from
Dec 16, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Dec 14, 2024

This pull request will Merge branch dev to main.

Before merging this PR

  • Pull translations from Crowdin

LisoUseInAIKyrios and others added 5 commits December 15, 2024 00:15
## [5.4.1-dev.1](v5.4.0...v5.4.1-dev.1) (2024-12-14)

### Bug Fixes

* **Twitch:** Change recommended target to the latest app version ([fb32972](fb32972))
# [5.5.0-dev.1](v5.4.1-dev.1...v5.5.0-dev.1) (2024-12-15)

### Features

* **YouTube:** Add `Force original audio` patch ([#4122](#4122)) ([f4aa440](f4aa440))
oSumAtrIX and others added 4 commits December 16, 2024 19:07
# [5.5.0-dev.2](v5.5.0-dev.1...v5.5.0-dev.2) (2024-12-16)

### Bug Fixes

* **YouTube Music:** Add `Spoof client patch` to fix playback ([#4132](#4132)) ([b092508](b092508))
# [5.5.0-dev.3](v5.5.0-dev.2...v5.5.0-dev.3) (2024-12-16)

### Features

* **YouTube - Hide feed components:** Remove obsolete `Hide search result shelf header` option ([#4134](#4134)) ([c71443a](c71443a))
@oSumAtrIX
Copy link
Member

Can merge after #4137 and #4137 as it contains a fix for music playback

LisoUseInAIKyrios and others added 4 commits December 16, 2024 22:43
# [5.5.0-dev.4](v5.5.0-dev.3...v5.5.0-dev.4) (2024-12-16)

### Bug Fixes

* **YouTube - Spoof video streams:** Make livestreams start at the current time when using iOS client   ([#4137](#4137)) ([140f484](140f484))
# [5.5.0-dev.5](v5.5.0-dev.4...v5.5.0-dev.5) (2024-12-16)

### Features

* **YouTube - Navigation buttons:** Add options to disable translucent status bar and navigation bar ([#4133](#4133)) ([a2d2141](a2d2141))
@oSumAtrIX oSumAtrIX requested review from oSumAtrIX and LisoUseInAIKyrios and removed request for oSumAtrIX December 16, 2024 19:21
@oSumAtrIX oSumAtrIX marked this pull request as ready for review December 16, 2024 19:22
@oSumAtrIX oSumAtrIX self-requested a review December 16, 2024 19:22
@oSumAtrIX oSumAtrIX merged commit ccea384 into main Dec 16, 2024
2 checks passed
@MarcaDian
Copy link
Contributor

MarcaDian commented Dec 16, 2024

There some strings issues

Screenshot_2024-12-16-21-38-25-828_app.revanced.manager.flutter.jpg

- Device Info
ReVanced Manager: 1.23.2
Model: 23124RA7EO
Android version: 14
Supported architectures: arm64-v8a, armeabi-v7a, armeabi
Root permissions: No

- Patch Info
App: com.google.android.youtube v19.46.42 (Suggested: 19.46.42)
Patches version: v5.5.0
Patches added: Enable slide to seek
Patches removed: Announcements
Default patch options changed: None

- Settings
Allow changing patch selection: true
Version compatibility check: false
Show universal patches: false
Patches source: revanced/revanced-patches

- Logs
Reading APK
Decoding app manifest
Loading patches
Deleting existing temporary files directory
Decoding resources
Initializing lookup maps
Executing patches
Applied 54 patches
String revanced_check_watch_history_domain_name_dialog_message is not raw but contains encoded new line characters: Seerhistorikken din lagres ikke.

Dette er sannsynligvis forårsaket av en DNS-annonseblokkering eller nettverksproxy.

For å fikse dette, hvitlist <b>s.youtube.com</b> eller slå av alle DNS-blokkeringer og proxyer.
String revanced_hide_join_membership_button_title cannot contain unescaped quotes in value: Skjul 'Bli med'-knappen
String revanced_hide_for_you_shelf_title cannot contain unescaped quotes in value: Skjul 'For deg'-hylle på kanalsiden
String revanced_hide_notify_me_button_title cannot contain unescaped quotes in value: Skjul 'Varsle meg'-knappen
String revanced_hide_search_result_recommendations_title cannot contain unescaped quotes in value: Skjul anbefalinger for 'Andre så også'
String revanced_hide_show_more_button_title cannot contain unescaped quotes in value: Skjul 'Vis mer'-knappen
String revanced_hide_keyword_content_about_whole_words_summary is not raw but contains encoded new line characters: Å sette søkeord/uttrykk i anførselstegn vil forhindre delvise treff for videotitler og kanalnavn

For eksempel,
\"ai\" vil skjule videoen: Hvordan fungerer AI?
men vil ikke skjule: Hva betyr rimelig bruk?
Compiling modified resources
An error occurred:
brut.androlib.exceptions.AndrolibException: brut.common.BrutException: could not exec (exit code = 1): [/data/app/~~XJLBjyVSnFmAACX863qO1Q==/app.revanced.manager.flutter-lNHHmxJoxPDq4hWEkcYkVA==/lib/arm64/libaapt2.so, compile, --dir, /data/user/0/app.revanced.manager.flutter/files/patcher/tmp-NVFMIS/revanced-temporary-files/apk/res, --legacy, -o, /data/user/0/app.revanced.manager.flutter/files/patcher/tmp-NVFMIS/revanced-temporary-files/apk/build/resources.zip]
	at brut.androlib.AaptInvoker.invokeAapt2(SourceFile:123)
	at brut.androlib.AaptInvoker.invokeAapt(SourceFile:394)
	at app.revanced.patcher.patch.ResourcePatchContext.get(SourceFile:133)
	at app.revanced.patcher.Patcher.get(SourceFile:159)
	at app.revanced.manager.flutter.MainActivity.runPatcher$lambda$34(SourceFile:338)
	at app.revanced.manager.flutter.MainActivity.$r8$lambda$_NYn7P0Ss3RCL0-SqEFL-opMsQw(SourceFile:0)
	at app.revanced.manager.flutter.MainActivity$$ExternalSyntheticLambda6.run(SourceFile:0)
	at java.lang.Thread.run(Thread.java:1012)
Caused by: brut.common.BrutException: could not exec (exit code = 1): [/data/app/~~XJLBjyVSnFmAACX863qO1Q==/app.revanced.manager.flutter-lNHHmxJoxPDq4hWEkcYkVA==/lib/arm64/libaapt2.so, compile, --dir, /data/user/0/app.revanced.manager.flutter/files/patcher/tmp-NVFMIS/revanced-temporary-files/apk/res, --legacy, -o, /data/user/0/app.revanced.manager.flutter/files/patcher/tmp-NVFMIS/revanced-temporary-files/apk/build/resources.zip]
	at brut.util.OS.exec(SourceFile:104)
	at brut.androlib.AaptInvoker.invokeAapt2(SourceFile:119)
	... 7 more

@LisoUseInAIKyrios
Copy link
Contributor

The translations were last synced when Crowdin was being restored. Need another release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants