fix: Directly save APK to the cache when saving last patched app #2332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should hopefully solve the issue where it can't write the patched app for some reason
|
This needs to be tested before merging. I can't get the original issue to appear. |
|
According to the doc, this change should not make a difference: |
BenjaminHalko
changed the title
Does this fix #2224? If yes, you can send me an APK with the changes and I'll test it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should hopefully solve the issue where it can't write the patched app for some reasonInstead of copying the APK from the temp patcher directory after patching is complete, the patcher will just save the APK to the directory to begin with.