This repository has been archived by the owner on Oct 26, 2024. It is now read-only.
fix(YouTube - ReturnYouTubeDislike): Do not show more than 1 connection toasts if the API is broken #560
+79
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oSumAtrIX
approved these changes
Jan 29, 2024
…on toasts if the API is broken
LisoUseInAIKyrios
force-pushed
the
ryd_backoff_toast
branch
from
ec8a841 to
bc6241a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The connection toast now shows just once until an API call is completed successfully.
The patch will still keep trying to use the API during this toast backoff period, but it won't show anymore toasts until at least 1 API call is successful.
Useful for moments like now, since RYD is completely broken and all API calls are failing.
To RYD's credit this is the first time it's been 100% down in many years.