fix(YouTube - Hide description components): Replace `Hide game sectio…

…n` and `Hide music section` with `Hide attributes section` (#654) Co-authored-by: ILoveOpenSourceApplications <[email protected]>
ReVanced · Jun 17, 2024 · f82dfce · f82dfce
1 parent a1e358b
commit f82dfce
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 19 deletions.
diff --git a/...ava/app/revanced/integrations/youtube/patches/components/DescriptionComponentsFilter.java b/...ava/app/revanced/integrations/youtube/patches/components/DescriptionComponentsFilter.java
@@ -18,8 +18,15 @@ public DescriptionComponentsFilter() {
                 "metadata"
         );
 
-        final StringFilterGroup chapterSection = new StringFilterGroup(
-                Settings.HIDE_CHAPTERS,
+        final StringFilterGroup attributesSection = new StringFilterGroup(
+                Settings.HIDE_ATTRIBUTES_SECTION,
+                "gaming_section",
+                "music_section",
+                "video_attributes_section"
+        );
+
+        final StringFilterGroup chaptersSection = new StringFilterGroup(
+                Settings.HIDE_CHAPTERS_SECTION,
                 "macro_markers_carousel"
         );
 
@@ -28,17 +35,6 @@ public DescriptionComponentsFilter() {
                 "infocards_section"
         );
 
-        final StringFilterGroup gameSection = new StringFilterGroup(
-                Settings.HIDE_GAME_SECTION,
-                "gaming_section"
-        );
-
-        final StringFilterGroup musicSection = new StringFilterGroup(
-                Settings.HIDE_MUSIC_SECTION,
-                "music_section",
-                "video_attributes_section"
-        );
-
         final StringFilterGroup podcastSection = new StringFilterGroup(
                 Settings.HIDE_PODCAST_SECTION,
                 "playlist_section"
@@ -50,10 +46,9 @@ public DescriptionComponentsFilter() {
         );
 
         addPathCallbacks(
-                chapterSection,
+                attributesSection,
+                chaptersSection,
                 infoCardsSection,
-                gameSection,
-                musicSection,
                 podcastSection,
                 transcriptSection
         );

diff --git a/app/src/main/java/app/revanced/integrations/youtube/settings/Settings.java b/app/src/main/java/app/revanced/integrations/youtube/settings/Settings.java
@@ -155,10 +155,9 @@ public class Settings extends BaseSettings {
     public static final BooleanSetting HIDE_COMMENTS_TIMESTAMP_AND_EMOJI_BUTTONS = new BooleanSetting("revanced_hide_comments_timestamp_and_emoji_buttons", TRUE);
 
     // Description
-    public static final BooleanSetting HIDE_CHAPTERS = new BooleanSetting("revanced_hide_chapters", TRUE);
+    public static final BooleanSetting HIDE_ATTRIBUTES_SECTION = new BooleanSetting("revanced_hide_attributes_section", FALSE);
+    public static final BooleanSetting HIDE_CHAPTERS_SECTION = new BooleanSetting("revanced_hide_chapters_section", TRUE);
     public static final BooleanSetting HIDE_INFO_CARDS_SECTION = new BooleanSetting("revanced_hide_info_cards_section", TRUE);
-    public static final BooleanSetting HIDE_GAME_SECTION = new BooleanSetting("revanced_hide_game_section", TRUE);
-    public static final BooleanSetting HIDE_MUSIC_SECTION = new BooleanSetting("revanced_hide_music_section", TRUE);
     public static final BooleanSetting HIDE_PODCAST_SECTION = new BooleanSetting("revanced_hide_podcast_section", TRUE);
     public static final BooleanSetting HIDE_TRANSCRIPT_SECTION = new BooleanSetting("revanced_hide_transcript_section", TRUE);