Don't split characters into bytes for processing #109
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can copy the test from #108, I'm just not sure where is the right place. |
|
This fixes the related issue that affects me, but I think that in general, the input shouldn't be treated as bytes but as chars, given that it's already validated utf-8. |
|
I don't think this is the correct solution. You handle only the text node case. I will partially revert the old one. |
|
Yeah, I think that this is a partial solution (for my specific case), but I’m not entirely sure how to handle other cases or what those might be.
Didn’t the original commit fix a bug with \r\n ?
|
|
No. It was separate. And it would not be affected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #108