update dependency constrains #1147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| check-generate-grpc-code-in-sync: generate-grpc | ||
| check-generate-grpc-code-in-sync: ## check if the generated code is in sync with the proto files | ||
| # this is a helper to check if the generated code is in sync with the proto files | ||
| check-generate-grpc-code-in-sync: generate-grpc ## check if the generated code is in sync with the proto files, it uses a helper to check if the generated code is in sync with the proto files |
There was a problem hiding this comment.
Have you validated if this is not breaking make help target? Comment should be displayed as description for the target.
There was a problem hiding this comment.
@radovanZRasa Yes
❯ make help
...
check-generate-grpc-code-in-sync check if the generated code is in sync with the proto files, it uses a helper to check if the generated code is in sync with the proto files
...
radovanZRasa
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
Status (please check what you already did):
ruff(please check Readme for instructions)