Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ARM arch for rasa-sdk Docker images #1123

Merged
merged 7 commits into from
Jul 9, 2024
Merged

Add support for ARM arch for rasa-sdk Docker images #1123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
85cd0c4
add support for ARM arch
ancalita Jul 8, 2024
efe5d27
add changelog entry
ancalita Jul 8, 2024
8693935
trigger dev image build on PR
ancalita Jul 9, 2024
755c3cf
remove docker driver from dev image workflow
ancalita Jul 9, 2024
93e71cb
use --push instead of load flag
ancalita Jul 9, 2024
3f8e6f0
update override flag
ancalita Jul 9, 2024
cb4ac02
remove target from override flag
ancalita Jul 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions .github/workflows/continuous-integration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,21 +240,17 @@ jobs:
run: |
echo "IMAGE_TAG=${{ needs.build_docker_image_set_env.outputs.image_tag }}" >> $GITHUB_ENV

- name: Build Docker image
run: |
docker buildx bake --load

- name: Login to Docker Hub Registry 🔢
if: github.event_name == 'push' && env.IS_TAG_BUILD == 'true' && github.repository == 'RasaHQ/rasa-sdk'
run: echo ${{ secrets.DOCKER_HUB_PASSWORD }} | docker login -u ${{ secrets.DOCKER_HUB_USERNAME }} --password-stdin || true

- name: Push Docker image 📦
- name: Build and Push Docker image 📦
if: github.event_name == 'push' && env.IS_TAG_BUILD == 'true' && github.repository == 'RasaHQ/rasa-sdk'
run: |
IS_NEWEST_VERSION=${{ needs.build_docker_image_set_env.outputs.is_newest_version }}

# Push image
docker push rasa/rasa-sdk:${IMAGE_TAG}
IMAGE_TAG=${IMAGE_TAG} docker buildx bake --set *.platform=linux/amd64,linux/arm64 -f docker-bake.hcl default --push

# Tag the image as latest
if [[ "${IS_NEWEST_VERSION}" == "true" ]]; then
Expand Down
11 changes: 3 additions & 8 deletions .github/workflows/rasa-sdk-dev-docker-image.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ on:
# Run cron job at 8AM Monday to Sunday.
- cron: '0 8 * * *'
workflow_dispatch:
pull_request:

env:
AWS_REGION: us-east-1
Expand Down Expand Up @@ -48,13 +49,7 @@ jobs:
uses: docker/setup-buildx-action@4b4e9c3e2d4531116a6f8ba8e71fc6e2cb6e6c8c
with:
version: v0.5.1
driver: docker

- name: Build docker image
- name: Build and push docker image to AWS
run: |
docker buildx bake --load

- name: Tag and push docker image to AWS
run: |
docker tag rasa/rasa-sdk:main $REPOSITORY:latest
docker push $REPOSITORY:latest
docker buildx bake --set *.platform=linux/amd64,linux/arm64 --set default.tags=$REPOSITORY:latest --push
1 change: 1 addition & 0 deletions changelog/1123.misc.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Add support for ARM architecture in the `rasa-sdk` Docker image build.
Loading