Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ATO-2102] Instrument ValidationAction.run #1074

Merged
merged 6 commits into from
Feb 9, 2024

Conversation

Tawakalt
Copy link
Contributor

@Tawakalt Tawakalt commented Feb 9, 2024

Proposed changes:

View from Jaegar UI:
Screenshot 2024-02-09 at 14 57 00

Status (please check what you already did):

  • made PR ready for code review
  • added some tests for the functionality
  • updated the documentation in the rasaHQ/rasa
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@Tawakalt Tawakalt requested a review from ancalita February 9, 2024 13:19
@Tawakalt Tawakalt requested a review from ancalita February 9, 2024 15:22
Copy link
Member

@ancalita ancalita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

tests/test_endpoint.py Show resolved Hide resolved
@Tawakalt Tawakalt force-pushed the ATO-2102-instrument-ValidationAction.run branch from 6d48c4d to 66edd17 Compare February 9, 2024 15:42
@Tawakalt Tawakalt merged commit 71489ca into main Feb 9, 2024
16 checks passed
@Tawakalt Tawakalt deleted the ATO-2102-instrument-ValidationAction.run branch February 9, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants