Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ATO-2099] Instrument ActionExecutor.run method #1073

Merged
merged 6 commits into from
Feb 8, 2024
Merged

[ATO-2099] Instrument ActionExecutor.run method #1073

merged 6 commits into from
Feb 8, 2024

Conversation

Tawakalt
Copy link
Contributor

@Tawakalt Tawakalt commented Feb 7, 2024 •
edited
Loading

Proposed changes:

Views from Jaegar UI
Screenshot 2024-02-07 at 14 24 26
Screenshot 2024-02-07 at 14 24 34

Status (please check what you already did):

  • made PR ready for code review
  • added some tests for the functionality
  • updated the documentation in the rasaHQ/rasa
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@Tawakalt Tawakalt force-pushed the instrument-ActionExecutor.run-method branch from 0c1357f to 1192b9b Compare February 7, 2024 15:15
@Tawakalt Tawakalt requested a review from ancalita February 7, 2024 15:23
ancalita
ancalita reviewed Feb 8, 2024
View reviewed changes
Copy link
Member

@ancalita ancalita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 💯 Left a few improvement suggestions.

rasa_sdk/tracing/config.py Show resolved Hide resolved
rasa_sdk/tracing/config.py Show resolved Hide resolved
rasa_sdk/tracing/instrumentation/attribute_extractors.py Outdated Show resolved Hide resolved
rasa_sdk/tracing/instrumentation/instrumentation.py Outdated Show resolved Hide resolved
tests/tracing/instrumentation/test_action_executor.py Outdated Show resolved Hide resolved
@Tawakalt Tawakalt force-pushed the instrument-ActionExecutor.run-method branch from b12a62a to 2366b0c Compare February 8, 2024 11:34
@Tawakalt Tawakalt requested a review from ancalita February 8, 2024 11:37
@Tawakalt Tawakalt merged commit 552f409 into main Feb 8, 2024
16 checks passed
@Tawakalt Tawakalt deleted the instrument-ActionExecutor.run-method branch February 8, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ancalita ancalita ancalita approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tawakalt @ancalita