Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix connection to action server - [ENG 680] #1047

Merged
merged 3 commits into from
Nov 22, 2023
Merged

Fix connection to action server - [ENG 680] #1047

merged 3 commits into from
Nov 22, 2023

Conversation

varunshankar
Copy link
Contributor

Proposed changes:

  • Fixes ENG-680
  • set KEEP_ALIVE_TIMEOUT to 120

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@CLAassistant
Copy link

CLAassistant commented Nov 21, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@varunshankar varunshankar requested a review from tmbo November 21, 2023 14:58
@varunshankar varunshankar self-assigned this Nov 21, 2023
tmbo
tmbo approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@tmbo tmbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tmbo tmbo merged commit 541a7c9 into main Nov 22, 2023
16 checks passed
@tmbo tmbo deleted the ENG-680-DEFAULT_KEEP_ALIVE_TIMEOUT branch November 22, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmbo tmbo tmbo approved these changes

Assignees

@varunshankar varunshankar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@varunshankar @CLAassistant @tmbo