Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-Authored-By: Tobias Wochinger <[email protected]>
  • Loading branch information
akelad and wochinge authored Sep 27, 2019
1 parent 2eb9af7 commit 2577581
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 5 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ Removed

Added
-----
- SSL support, certificate can be passed with --ssl-certificate and --ssl-keyfile
- SSL support, certificates can be passed with --ssl-certificate and --ssl-keyfile


[1.3.2] - 2019-09-06
Expand Down
4 changes: 2 additions & 2 deletions rasa_sdk/cli/arguments.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,12 +36,12 @@ def add_endpoint_arguments(parser):
parser.add_argument(
"--ssl-keyfile",
default=None,
help="Set the SSL Certificate to create a TLS secured server.",
help="Set the SSL certificate to create a TLS secured server.",
)
parser.add_argument(
"--ssl-certificate",
default=None,
help="Set the SSL Certificate to create a TLS secured server.",
help="Set the SSL certificate to create a TLS secured server.",
)
parser.add_argument(
"--ssl-password",
Expand Down
3 changes: 1 addition & 2 deletions rasa_sdk/endpoint.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
from flask import Flask, jsonify, request
from flask_cors import CORS, cross_origin
from gevent.pywsgi import WSGIServer
from ssl import SSLContext

from rasa_sdk.cli.arguments import add_endpoint_arguments
from rasa_sdk.constants import DEFAULT_SERVER_PORT
Expand All @@ -25,7 +24,7 @@


def create_ssl_context(ssl_certificate, ssl_keyfile, ssl_password):
"""Create a SSL context if a proper certificate is passed."""
"""Create a SSL context if a certificate is passed."""

if ssl_certificate:
import ssl
Expand Down

0 comments on commit 2577581

Please sign in to comment.