Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use session limit max concurrency in a limited scope #10008

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mikeshardmind
Copy link
Contributor

@mikeshardmind mikeshardmind commented Nov 11, 2024

Summary

See #8430

This only applies when not clustering and when before_identify_hook has not been overridden.

This should limit the scope to bots that are slim enough to run in a single process yet large enough to have a raised max concurrency, without touching the behavior for bots that have already overridden this using the provided hook.

⚠️ I can't personally test this one.

It's built on top of changes in #10007

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

- Only takes effect when discord provides an increased max concurrency,
  user has not indicated clustering at all, and before_identify_hook has
  not been overriden

  This partially addresses Rapptz#8430

  This depends on a smaller change in Rapptz#10007

  I cannot personally test this change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant