secure TypeReflection for incorrect arg

Raphhh · Dec 28, 2015 · bbff6c7 · bbff6c7
1 parent 33617ca
commit bbff6c7
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/src/TypeReflection.php b/src/TypeReflection.php
@@ -1,6 +1,8 @@
 <?php
 namespace TRex\Reflection;
 
+use \InvalidArgumentException;
+
 
 /**
  * TypeReflection reflect the types.
@@ -390,8 +392,15 @@ private function getTypeMappingList()
      * @param string $standardizeType
      * @return array
      */
-    private function getTypeMapping($standardizeType = '')
+    private function getTypeMapping($standardizeType)
     {
+        if(!isset($this->getTypeMappingList()[$standardizeType])){
+            throw new InvalidArgumentException(sprintf(
+                '$standardizeType not valid. Should be on of the values: %s. "%s" given.',
+                json_encode($this->getStandardizedTypes()),
+                $standardizeType
+            ));
+        }
         return $this->getTypeMappingList()[$standardizeType];
     }
 

diff --git a/tests/TypeReflectionTest.php b/tests/TypeReflectionTest.php
@@ -155,6 +155,17 @@ public function tesIsCallable()
         }
     }
 
+    public function testIsWithoutValidStandardizedType()
+    {
+        $typeReflection = new TypeReflection('string');
+
+        $this->setExpectedException(
+            'InvalidArgumentException',
+            '$standardizeType not valid. Should be on of the values: ["void","mixed","null","boolean","string","integer","float","number","scalar","array","object","resource","callable"]. "foo" given.'
+        );
+        $this->assertFalse($typeReflection->is('foo'));
+    }
+
     /**
      * @param mixed $var
      * @param string $type