Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UI buttons to the pages #56

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add UI buttons to the pages #56

wants to merge 1 commit into from

Conversation

ronw98
Copy link

@ronw98 ronw98 commented Mar 26, 2021

I added 3 buttons (that can be shown or not):

  • A skip button that automatically calls the onRightOut listener
  • A previous button that goes back one page
  • A next button that goes forward one page

The text of the skip button is customizable
The next and previous buttons are ImageButtons with an arrow drawable. Its color can be changed in API 21+

I also added a builder for readability purposes.

These changes are compatible with the previous version of the library.

feat(*): add skip, next and previous buttons to page
52c878c 
add PaperOnboardingPage.Builder for readability
akardas16
akardas16 reviewed May 29, 2021
View reviewed changes
Copy link

@akardas16 akardas16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding buttons

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akardas16 akardas16 akardas16 left review comments

@michaelfarouk michaelfarouk michaelfarouk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ronw98 @michaelfarouk @akardas16