Remove backup slot number, 0 or 1, from Velero Backup request name
#872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hatfieldbrian <[email protected]>
- Use jq instead of json_to_yaml to format json Signed-off-by: hatfieldbrian <[email protected]>
|
It'd be useful if the Recipe e2e scripts were updated for this change, as well. I believe the only places required are here and here for the Protect step. Specifically, |
Signed-off-by: hatfieldbrian <[email protected]>
hatfieldbrian
added
the
low
|
@raghavendra-talur Do we still need this change? We may want to track it in an issue and open a new PR as required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A VRG writes to one backup slot number, 0 or 1, at a time per s3 profile. Velero
Backupname need not include the backup number. This patch removes it.Note that a
BackupStorageLocationmay result in aBackuprequest in an object store being recreated in Kube API server. However, a VRG'sBackupsandBackupStorageLocationsfor an s3 store are all deleted prior to a backup starting.