Restrict Event Booking to Verified Users #433
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -259,73 +259,43 @@ We extend our heartfelt gratitude to all the amazing contributors who have made | |
| <sub><b>Arindam</b></sub> | ||
| </a> | ||
| </td> | ||
| <td align="center"> | ||
| <a href="https://github.com/alo7lika"> | ||
| <img src="https://avatars.githubusercontent.com/u/152315710?v=4" width="100;" alt="alo7lika"/> | ||
| <br /> | ||
| <sub><b>alolika bhowmik</b></sub> | ||
| </a> | ||
| </td> | ||
| <td align="center"> | ||
| <a href="https://github.com/Ashwinib26"> | ||
| <img src="https://avatars.githubusercontent.com/u/149402720?v=4" width="100;" alt="Ashwinib26"/> | ||
| <br /> | ||
| <sub><b>Ashwini_ab</b></sub> | ||
| </a> | ||
| </td> | ||
| <td align="center"> | ||
| <a href="https://github.com/itznayan"> | ||
| <img src="https://avatars.githubusercontent.com/u/136584376?v=4" width="100;" alt="itznayan"/> | ||
| <br /> | ||
| <sub><b>Mahera Nayan</b></sub> | ||
| </a> | ||
| </td> | ||
| </tr> | ||
| <tr> | ||
| <td align="center"> | ||
| <a href="https://github.com/tejasbenibagde"> | ||
| <img src="https://avatars.githubusercontent.com/u/124677750?v=4" width="100;" alt="tejasbenibagde"/> | ||
| <br /> | ||
| <sub><b>Tejas Benibagde</b></sub> | ||
| </a> | ||
| </td> | ||
| <td align="center"> | ||
| <a href="https://github.com/Shirisha-16"> | ||
| <img src="https://avatars.githubusercontent.com/u/148051550?v=4" width="100;" alt="Shirisha-16"/> | ||
| <br /> | ||
| <sub><b>Tyarla Shirisha</b></sub> | ||
| </a> | ||
| </td> | ||
| <td align="center"> | ||
| <a href="https://github.com/Amnyadav"> | ||
| <img src="https://avatars.githubusercontent.com/u/127370497?v=4" width="100;" alt="Amnyadav"/> | ||
|
|
@@ -341,17 +311,10 @@ We extend our heartfelt gratitude to all the amazing contributors who have made | |
| </a> | ||
| </td> | ||
| <td align="center"> | ||
| <a href="https://github.com/haseebzaki-07"> | ||
| <img src="https://avatars.githubusercontent.com/u/147314463?v=4" width="100;" alt="haseebzaki-07"/> | ||
| <br /> | ||
| <sub><b>Haseeb Zaki</b></sub> | ||
| </a> | ||
| </td> | ||
| <td align="center"> | ||
|
|
@@ -361,15 +324,15 @@ We extend our heartfelt gratitude to all the amazing contributors who have made | |
| <sub><b>Sawan kushwah </b></sub> | ||
| </a> | ||
| </td> | ||
| </tr> | ||
| <tr> | ||
| <td align="center"> | ||
| <a href="https://github.com/Suhas-Koheda"> | ||
| <img src="https://avatars.githubusercontent.com/u/72063139?v=4" width="100;" alt="Suhas-Koheda"/> | ||
| <br /> | ||
| <sub><b>Suhas Koheda</b></sub> | ||
| </a> | ||
| </td> | ||
| <td align="center"> | ||
| <a href="https://github.com/Jay-1409"> | ||
| <img src="https://avatars.githubusercontent.com/u/166749819?v=4" width="100;" alt="Jay-1409"/> | ||
|
|
@@ -384,13 +347,6 @@ We extend our heartfelt gratitude to all the amazing contributors who have made | |
| <sub><b>Vishnu Prasad Korada</b></sub> | ||
| </a> | ||
| </td> | ||
| <td align="center"> | ||
| <a href="https://github.com/sajalbatra"> | ||
| <img src="https://avatars.githubusercontent.com/u/125984550?v=4" width="100;" alt="sajalbatra"/> | ||
|
|
@@ -422,10 +378,10 @@ We extend our heartfelt gratitude to all the amazing contributors who have made | |
| </a> | ||
| </td> | ||
| <td align="center"> | ||
| <a href="https://github.com/VinayLodhi1712"> | ||
| <img src="https://avatars.githubusercontent.com/u/135756009?v=4" width="100;" alt="VinayLodhi1712"/> | ||
| <br /> | ||
| <sub><b>Vinay Anand Lodhi</b></sub> | ||
| </a> | ||
| </td> | ||
| <td align="center"> | ||
|
|
@@ -435,13 +391,6 @@ We extend our heartfelt gratitude to all the amazing contributors who have made | |
| <sub><b>Vishal Lade</b></sub> | ||
| </a> | ||
| </td> | ||
| <td align="center"> | ||
| <a href="https://github.com/REHAN-18"> | ||
| <img src="https://avatars.githubusercontent.com/u/143922855?v=4" width="100;" alt="REHAN-18"/> | ||
|
|
@@ -456,22 +405,15 @@ We extend our heartfelt gratitude to all the amazing contributors who have made | |
| <sub><b>t rahul prabhu</b></sub> | ||
| </a> | ||
| </td> | ||
| <td align="center"> | ||
| <a href="https://github.com/Aditya90456"> | ||
| <img src="https://avatars.githubusercontent.com/u/153073510?v=4" width="100;" alt="Aditya90456"/> | ||
| <br /> | ||
| <sub><b>Aditya Bakshi</b></sub> | ||
| </a> | ||
| </td> | ||
| </tr> | ||
| <tr> | ||
| <td align="center"> | ||
| <a href="https://github.com/tanishirai"> | ||
| <img src="https://avatars.githubusercontent.com/u/178164785?v=4" width="100;" alt="tanishirai"/> | ||
|
|
@@ -487,26 +429,17 @@ We extend our heartfelt gratitude to all the amazing contributors who have made | |
| </a> | ||
| </td> | ||
| <td align="center"> | ||
| <a href="https://github.com/Sourabh782"> | ||
| <img src="https://avatars.githubusercontent.com/u/103349890?v=4" width="100;" alt="Sourabh782"/> | ||
| <br /> | ||
| <sub><b>Sourabh Singh Rawat</b></sub> | ||
| </a> | ||
| </td> | ||
| <td align="center"> | ||
| <a href="https://github.com/Shiva-Bajpai"> | ||
| <img src="https://avatars.githubusercontent.com/u/141490705?v=4" width="100;" alt="Shiva-Bajpai"/> | ||
| <br /> | ||
| <sub><b>Shiva Bajpai</b></sub> | ||
| </a> | ||
| </td> | ||
| <td align="center"> | ||
|
|
@@ -516,20 +449,15 @@ We extend our heartfelt gratitude to all the amazing contributors who have made | |
| <sub><b>MANI </b></sub> | ||
| </a> | ||
| </td> | ||
| <td align="center"> | ||
| <a href="https://github.com/Ayush215mb"> | ||
| <img src="https://avatars.githubusercontent.com/u/154300084?v=4" width="100;" alt="Ayush215mb"/> | ||
| <br /> | ||
| <sub><b>Ayush Yadav</b></sub> | ||
| </a> | ||
| </td> | ||
| </tr> | ||
| <tr> | ||
| <td align="center"> | ||
| <a href="https://github.com/smog-root"> | ||
| <img src="https://avatars.githubusercontent.com/u/181578777?v=4" width="100;" alt="smog-root"/> | ||
|
|
@@ -544,8 +472,6 @@ We extend our heartfelt gratitude to all the amazing contributors who have made | |
| <sub><b>Vaibhav._Y</b></sub> | ||
| </a> | ||
| </td> | ||
| <td align="center"> | ||
| <a href="https://github.com/Vaibhav-Kumar-K-R"> | ||
| <img src="https://avatars.githubusercontent.com/u/132189791?v=4" width="100;" alt="Vaibhav-Kumar-K-R"/> | ||
|
|
@@ -574,22 +500,15 @@ We extend our heartfelt gratitude to all the amazing contributors who have made | |
| <sub><b>Sapna Kul</b></sub> | ||
| </a> | ||
| </td> | ||
| </tr> | ||
| <tr> | ||
| <td align="center"> | ||
| <a href="https://github.com/MutiatBash"> | ||
| <img src="https://avatars.githubusercontent.com/u/108807732?v=4" width="100;" alt="MutiatBash"/> | ||
| <br /> | ||
| <sub><b>Bashua Mutiat</b></sub> | ||
| </a> | ||
| </td> | ||
| <td align="center"> | ||
| <a href="https://github.com/Mohitranag18"> | ||
| <img src="https://avatars.githubusercontent.com/u/152625405?v=4" width="100;" alt="Mohitranag18"/> | ||
|
|
@@ -604,20 +523,6 @@ We extend our heartfelt gratitude to all the amazing contributors who have made | |
| <sub><b>Jai Dhingra</b></sub> | ||
| </a> | ||
| </td> | ||
| <td align="center"> | ||
| <a href="https://github.com/mishradev1"> | ||
| <img src="https://avatars.githubusercontent.com/u/118660840?v=4" width="100;" alt="mishradev1"/> | ||
|
|
@@ -632,8 +537,6 @@ We extend our heartfelt gratitude to all the amazing contributors who have made | |
| <sub><b>CHIKATLA RAKESH</b></sub> | ||
| </a> | ||
| </td> | ||
| <td align="center"> | ||
| <a href="https://github.com/AliGates915"> | ||
| <img src="https://avatars.githubusercontent.com/u/128673394?v=4" width="100;" alt="AliGates915"/> | ||
|
|
@@ -697,7 +600,4 @@ Stay updated and engage with our community on social media: | |
| - [LinkedIn](https://www.linkedin.com/in/ramakrushna-biswal/) | ||
| - [Email](mailto:[email protected]) | ||
|
|
||
| We are always here to help you! Don’t hesitate to connect with us and be part of the PlayCafe journey. | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -5,6 +5,7 @@ const { | |||||
| getEvents, | ||||||
| deleteEvent, | ||||||
| } = require("../controller/event.controller"); | ||||||
| const authenticateCustomer = require("../middlewares/authCustomer"); | ||||||
|
|
||||||
| const router = express.Router(); | ||||||
|
|
||||||
|
|
@@ -24,8 +25,11 @@ router.get("/", async (req, res) => { | |||||
| res.status(500).json({ error: "Internal server error" }); | ||||||
| } | ||||||
| }); | ||||||
|
|
||||||
|
|
||||||
| router.post("/create",authenticateCustomer, createEvent); | ||||||
| router.get("/all",authenticateCustomer, getEvents); | ||||||
| router.get("/delete",authenticateCustomer, deleteEvent); | ||||||
|
There was a problem hiding this comment. Use DELETE HTTP method for delete operations. Using GET for delete operations violates REST principles and could lead to unintended consequences (e.g., search engine crawlers accidentally deleting resources). Consider changing to DELETE method. -router.get("/delete", authenticateCustomer, deleteEvent);
+router.delete("/delete", authenticateCustomer, deleteEvent);📝 Committable suggestion
Suggested change
Comment on lines
+30
to
+32
There was a problem hiding this comment. 💡 Codebase verification Authentication should not be required for GET /all endpoint The Event.jsx component shows that event listings are meant to be public, with authentication only required for event registration. This is evidenced by:
The current authentication middleware on GET /all conflicts with this design and should be removed. 🔗 Analysis chainVerify if authentication is required for GET /all endpoint. Based on the PR objectives to "Restrict Event Booking to Verified Users", it's unclear if viewing events should also be restricted. Consider if this aligns with the business requirements, as typically event listings are public while booking/modifications are restricted. 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Check if there are any public-facing components that might need this event data
rg -l "getEvents|/event/all" --type js --type jsx --type ts --type tsx
Length of output: 100 Script: #!/bin/bash
# Check for frontend components or API calls related to events listing
rg -l "getEvents|/events/all|/event/all" --type js
# Check if there are any public routes or components related to events
rg "router\.(get|post)\s*\(['\"].*event" --type js -A 2
# Look for any event-related components or pages
fd -e js -e jsx -e ts -e tsx | xargs rg "event" -i -l
Length of output: 1692 Script: #!/bin/bash
# Check the Event.jsx component to see if it's a public-facing page
cat frontend/src/components/Pages/Event.jsx
# Check the router configuration to see how the event page is configured
cat frontend/src/router/index.jsx
# Check the event controller implementation
cat backend/controller/event.controller.js
Length of output: 14848 |
||||||
|
|
||||||
|
|
||||||
| module.exports = router; | ||||||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Handle malformed Authorization headers to prevent potential errors
The current implementation assumes that the
Authorizationheader is in the format'Bearer <token>'. If the header is present but not in the expected format,tokenwill beundefined, and the user will receive a misleading error message.Apply this diff to improve header parsing and provide more informative feedback:
const token = req.header("Authorization")?.split(" ")[1]; -if (!token) { - return res.status(401).json({ message: "Authorization token is missing" }); +const authHeader = req.header("Authorization"); +if (!authHeader || !authHeader.startsWith("Bearer ")) { + return res.status(401).json({ message: "Invalid Authorization header format" }); +} +const token = authHeader.split(" ")[1];📝 Committable suggestion