-
-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed unintended page reloading issue #380
fixed unintended page reloading issue #380
Conversation
@Sumanbhadra is attempting to deploy a commit to the bunty's projects Team on Vercel. A member of the Team first needs to authorize it. |
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊 |
WalkthroughThe changes in this pull request involve updating the Changes
Assessment against linked issues
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
frontend/src/components/Shared/footer/Content.jsx (1)
119-125
: LGTM: Correct implementation of React Router's Link component.The replacement of anchor tags with Link components effectively addresses the issue of unintended page reloads for internal navigation. This change aligns perfectly with the PR objectives.
For consistency and improved accessibility, consider adding an
aria-label
to the Link components, similar to what's done for the social links:<Link className="hover:text-white duration-300" key={index} to={item.link} aria-label={`Navigate to ${item.name}`} > {item.name} </Link>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- frontend/src/components/Shared/footer/Content.jsx (2 hunks)
🧰 Additional context used
🔇 Additional comments (2)
frontend/src/components/Shared/footer/Content.jsx (2)
6-6
: LGTM: Necessary import for React Router's Link component.This import is crucial for implementing client-side routing and addresses the issue of unintended page reloads mentioned in the PR objectives.
Line range hint
1-164
: Great job addressing the unintended page reloading issue!The changes implemented in this PR effectively solve the problem of unintended page reloads when clicking on footer links. By replacing anchor tags with React Router's Link components for internal navigation, you've improved the user experience and application performance.
Key points:
- The import of the Link component is correctly added.
- The Nav component now uses Link for internal navigation, preventing full page reloads.
- External links (social media) correctly remain as anchor tags.
These changes align perfectly with the PR objectives and resolve the issue described in #349. The implementation is clean and focused, without introducing any unrelated modifications.
514a047
into
RamakrushnaBiswal:main
Fixes: #349
I changed the anchor tags to the Link tag of react-router-dom to prevent reloading.
Testing:
1022.mp4
@RamakrushnaBiswal take a look.
Summary by CodeRabbit
New Features
Link
component, improving the user experience with faster transitions between pages.Bug Fixes
Link
components to prevent full page reloads during navigation.