Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed unintended page reloading issue #380

Conversation

Sumanbhadra
Copy link
Contributor

@Sumanbhadra Sumanbhadra commented Oct 22, 2024

Fixes: #349

I changed the anchor tags to the Link tag of react-router-dom to prevent reloading.

Testing:

1022.mp4

@RamakrushnaBiswal take a look.

Summary by CodeRabbit

  • New Features

    • Enhanced navigation by integrating client-side routing with the Link component, improving the user experience with faster transitions between pages.
  • Bug Fixes

    • Replaced standard anchor tags with Link components to prevent full page reloads during navigation.

Copy link

vercel bot commented Oct 22, 2024

@Sumanbhadra is attempting to deploy a commit to the bunty's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link
Contributor

coderabbitai bot commented Oct 22, 2024

Walkthrough

The changes in this pull request involve updating the Nav component within the Content.jsx file to utilize the Link component from react-router-dom instead of standard anchor (<a>) tags. This adjustment aims to improve client-side navigation by preventing full page reloads when footer links are clicked, thus enhancing the routing capabilities of the application.

Changes

File Path Change Summary
frontend/src/components/Shared/footer/Content.jsx Replaced <a> tags with <Link> components for navigation links, updating href to to attributes. Added import for Link.

Assessment against linked issues

Objective Addressed Explanation
Prevent unintended page reloads on footer link click (#349)

Possibly related PRs

  • Refactor routing and improve layout with Navbar and Footer #20: This PR involves replacing <a> tags with <Link> components in the Navbar, which is directly related to the changes made in the Content.jsx file regarding navigation links.
  • Fix: footer links #289: This PR modifies the Content.jsx file to update navigation links, which aligns with the changes made in the main PR that also focuses on enhancing navigation through the use of the Link component.

Suggested labels

bug, enhancement, gssoc-ext

Suggested reviewers

  • RamakrushnaBiswal

🐇 In the footer, links now hop,
No more reloads, just a quick stop.
With Link in place, we navigate,
A smoother path, oh, isn’t it great?
So click away, don’t hesitate! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
frontend/src/components/Shared/footer/Content.jsx (1)

119-125: LGTM: Correct implementation of React Router's Link component.

The replacement of anchor tags with Link components effectively addresses the issue of unintended page reloads for internal navigation. This change aligns perfectly with the PR objectives.

For consistency and improved accessibility, consider adding an aria-label to the Link components, similar to what's done for the social links:

<Link
  className="hover:text-white duration-300"
  key={index}
  to={item.link}
  aria-label={`Navigate to ${item.name}`}
>
  {item.name}
</Link>
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 81cc864 and 97d306a.

📒 Files selected for processing (1)
  • frontend/src/components/Shared/footer/Content.jsx (2 hunks)
🧰 Additional context used
🔇 Additional comments (2)
frontend/src/components/Shared/footer/Content.jsx (2)

6-6: LGTM: Necessary import for React Router's Link component.

This import is crucial for implementing client-side routing and addresses the issue of unintended page reloads mentioned in the PR objectives.


Line range hint 1-164: Great job addressing the unintended page reloading issue!

The changes implemented in this PR effectively solve the problem of unintended page reloads when clicking on footer links. By replacing anchor tags with React Router's Link components for internal navigation, you've improved the user experience and application performance.

Key points:

  1. The import of the Link component is correctly added.
  2. The Nav component now uses Link for internal navigation, preventing full page reloads.
  3. External links (social media) correctly remain as anchor tags.

These changes align perfectly with the PR objectives and resolve the issue described in #349. The implementation is clean and focused, without introducing any unrelated modifications.

@RamakrushnaBiswal RamakrushnaBiswal merged commit 514a047 into RamakrushnaBiswal:main Oct 22, 2024
4 of 5 checks passed
@RamakrushnaBiswal RamakrushnaBiswal added bug Something isn't working level1 for 10 points gssoc-ext gssoc-extd program hacktoberfest accepted hacktoberfest-accepted repo labels Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gssoc-ext gssoc-extd program hacktoberfest accepted hacktoberfest-accepted repo level1 for 10 points
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Unintended Page Reloads on Footer Link Click
2 participants