Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Langs check #2006

Merged
merged 4 commits into from
Nov 25, 2024
Merged

Langs check #2006

merged 4 commits into from
Nov 25, 2024

Conversation

ia
Copy link
Collaborator

@ia ia commented Nov 22, 2024

  • Please check if the PR fulfills these requirements
  • The changes have been tested locally
  • There are no breaking changes
  • What kind of change does this PR introduce?
    Autocheck between json files with translations and enabled builds in source/Makefile.

  • What is the current behavior?
    If translation is added as translation_LANG.json, then we have not to forget manually add LANG to ALL_LANGUAGES inside source/Makefile.

  • What is the new behavior (if this is a feature change)?
    scripts/deploy.sh update with related autocheck.

  • Other information:

The test will be intentionally broken just for the demo purposes only. I will revert source/Makefile once I will test the autotest.

@ia ia added Translations Linguas, i18n & l10. Build System make/bash/python, github CI/CD & pals. labels Nov 22, 2024
@ia ia requested review from Ralim and discip November 22, 2024 17:28
@ia ia self-assigned this Nov 22, 2024
@ia
Copy link
Collaborator Author

ia commented Nov 22, 2024

Here is how it should be looking in the case of the further mismatch.

Copy link
Owner

@Ralim Ralim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat idea, I like it 🙇🏼
I also hope I dont need to debug the regex'ing as thats gonna be fun to check; I'm taking that one on trust ;)

@Ralim Ralim merged commit c607e73 into Ralim:dev Nov 25, 2024
18 checks passed
@ia
Copy link
Collaborator Author

ia commented Nov 26, 2024

Neat idea, I like it 🙇🏼

Thanks.

I also hope I dont need to debug the regex'ing

Me neither.

as thats gonna be fun to check

In a couple of months it will be true for me as well. ;)

I'm taking that one on trust ;)

I really appreciate this. So putting all jokes aside, just ping me/mention me once you or anyone else will notice any false positive or negative trigger, and I will try to fix any problems with that as fast as I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build System make/bash/python, github CI/CD & pals. Translations Linguas, i18n & l10.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants