-
-
Notifications
You must be signed in to change notification settings - Fork 722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check the presence of changelog for the latest stable release in History.md #1999
Conversation
…for easiest automation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ia
Although I understand roughly what this does, I not capable to approve your changes as I am not a programmer and therefore lack the necessary expertise. 😅
So you will have to wait for Ralim to approve it.
Oh, sure. The thing is, it seems something slightly changed with PR submission recently: before Ralim and you would be added automatically as reviewers for my PRs (which was convenient) but now it seems GitHub uses some sort of AI "guessing" who is more "relevant" for each PR. 🤷♂️ So now I just have to be more careful to make sure that both of you are included just in case. The bottom line is the point was include both of you as always just in case but I think GitHub included originally only you first or no one at all. So, that's what happened so you know. |
aka I will always forget as I'm terrible at remembering stuff like this I absolutely love this
It will break the CI build when I make the tag. Which isn't the best time to break but its a lot better than not. As that will poke me at the least. Once this is merged I'll update the expected CI values too (since check_readme wont exist) Are you feeling happy with this @ia ? |
Thanks. :)
I know, right? Exactly the point. Just right after new release tag
A, oh, yeah... at first I didn't get it but now I think I got it: I was thinking to keep Let the machines do the machinery. ;)
Sure! As always happy to be useful. |
What kind of change does this PR introduce?
Detecting the presence of changelog for the latest stable release in
History.md
.What is the current behavior?
We should add changelog manually but sometimes we may forget because there is no any test check for this.
What is the new behavior (if this is a feature change)?
Extend test step for docs using GitHub Actions with the following algorithm: check
History.md
for the latest stable release, checkgit tag
for the latest stable release, and if they mismatch then trigger error.Other information:
Not sure how it will work at the moment of tagging though. I guess we will see. :)
But basically now the push of the new release tag to
dev
must be with the same commit of changelog toHistory.md
. Otherwise there will be a reminder in the form of red build, but next commit of changes toHistory.md
probably will fix it. That's the point after all.Another one important notice for contributors, or what's new today I learned about git/hub: sometimes tags must be synced manually because for some reason just merging with upstream is not enough to sync some metadata such as tags, i.e.:
Without this, Actions in forked repos may not be fetching the latest actual git tags from
upstream
even if anything else is properly merged, synced, and up-to-dated. 🤷♂️