Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MHP30: Re-tuning PID #1961

Draft
wants to merge 11 commits into
base: dev
Choose a base branch
from
+17 −9
Draft

MHP30: Re-tuning PID #1961

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
17ac550
second attemp draft PR
tomasrojasc Aug 2, 2024
bcb08ad
setting I, D to zero, experimenting with just P
tomasrojasc Aug 3, 2024
52a57d4
settong P to 30
tomasrojasc Aug 3, 2024
896bbd0
new PID parameters to compare with cloud compilation
tomasrojasc Aug 5, 2024
c6705ac
Update Makefile
tomasrojasc Aug 14, 2024
c336ec7
Update source/Core/BSP/Pinecilv2/configuration.h
tomasrojasc Aug 14, 2024
2001093
returning to original parameters in Pinecil_V2
tomasrojasc Aug 14, 2024
c3f6de1
adding working PID parameters to MHP30
tomasrojasc Aug 14, 2024
ba58d95
removing thermal runaway
tomasrojasc Oct 14, 2024
3c54811
Update Soldering.cpp
discip Nov 1, 2024
24d7742
Set ADC input pins to INPUT mode instead of ANALOG
Ralim Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions source/Core/BSP/MHP30/configuration.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,14 @@
#define ACCEL_EXITS_ON_MOVEMENT
#define NEEDS_VBUS_PROBE 0

#define CANT_DIRECT_READ_SETTINGS // We cant memcpy settings due to flash cache
#define TIP_CONTROL_PID // We use PID rather than integrator
#define TIP_PID_KP 22 //40 // Reasonable compromise for most tips so far
#define TIP_PID_KI 300 //6 // About as high for stability across tips
#define TIP_PID_KD 600 //200 // Helps dampen smaller tips; ~= nothing for larger tips
#define FILTER_DISPLAYED_TIP_TEMP 8 // Filtering for GUI display


#define HARDWARE_MAX_WATTAGE_X10 650
#define TIP_THERMAL_MASS 65 // TODO, needs refinement
#define TIP_RESISTANCE 60 // x10 ohms, ~6 typical
Expand Down
6 changes: 3 additions & 3 deletions source/Core/BSP/MHP30/stm32f1xx_hal_msp.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,16 +57,16 @@ void HAL_ADC_MspInit(ADC_HandleTypeDef *hadc) {
PB1 ------> ADC2_IN9
*/
GPIO_InitStruct.Pin = TIP_TEMP_Pin;
GPIO_InitStruct.Mode = GPIO_MODE_ANALOG;
GPIO_InitStruct.Mode = GPIO_MODE_INPUT;
HAL_GPIO_Init(TIP_TEMP_GPIO_Port, &GPIO_InitStruct);
GPIO_InitStruct.Pin = TMP36_INPUT_Pin;
GPIO_InitStruct.Mode = GPIO_MODE_INPUT;
HAL_GPIO_Init(TMP36_INPUT_GPIO_Port, &GPIO_InitStruct);
GPIO_InitStruct.Pin = VIN_Pin;
GPIO_InitStruct.Mode = GPIO_MODE_ANALOG;
GPIO_InitStruct.Mode = GPIO_MODE_INPUT;
HAL_GPIO_Init(VIN_GPIO_Port, &GPIO_InitStruct);
GPIO_InitStruct.Pin = PLATE_SENSOR_Pin;
GPIO_InitStruct.Mode = GPIO_MODE_ANALOG;
GPIO_InitStruct.Mode = GPIO_MODE_INPUT;
HAL_GPIO_Init(PLATE_SENSOR_GPIO_Port, &GPIO_InitStruct);

/* ADC2 interrupt Init */
Expand Down
12 changes: 6 additions & 6 deletions source/Core/Threads/UI/logic/Soldering.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,11 +163,11 @@ OperatingMode gui_solderingMode(const ButtonState buttons, guiContext *cxt) {
return OperatingMode::Sleeping;
}

if (heaterThermalRunaway) {
currentTempTargetDegC = 0; // heater control off
heaterThermalRunaway = false;
cxt->transitionMode = TransitionAnimation::Right;
return OperatingMode::ThermalRunaway;
}
// if (heaterThermalRunaway) {
// currentTempTargetDegC = 0; // heater control off
// heaterThermalRunaway = false;
// cxt->transitionMode = TransitionAnimation::Right;
// return OperatingMode::ThermalRunaway;
// }
return handleSolderingButtons(buttons, cxt);
}