Merge pull request #18 from RadicalxChange/92_division_rounding

remove numerator denominator control
RadicalxChange · May 7, 2024 · 1c4021c · 1c4021c
2 parents 56617e2 + 21aac5f
commit 1c4021c
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 11 deletions.
diff --git a/contracts/pco/PeriodicPCOParamsInternal.sol b/contracts/pco/PeriodicPCOParamsInternal.sol
@@ -17,7 +17,7 @@ abstract contract PeriodicPCOParamsInternal is IPeriodicPCOParamsInternal {
         uint256 feeDenominator
     ) internal {
         require(
-            feeDenominator > feeNumerator && feeDenominator < 10_001,
+            feeDenominator < 10_001,
             'PeriodicPCOParamsInternal: invalid fee'
         );
 

diff --git a/test/pco/PeriodicPCOParams.ts b/test/pco/PeriodicPCOParams.ts
@@ -122,16 +122,6 @@ describe('PeriodicPCOParams', function () {
       ).to.be.revertedWith('PeriodicPCOParamsInternal: invalid fee');
     });
 
-    it('should not set numerator higher than denominator', async function () {
-      const factory = await ethers.getContractFactory('PeriodicPCOParamsFacet');
-      const instance = await factory.deploy();
-      await instance.deployed();
-
-      await expect(
-        instance['initializePCOParams(uint256,uint256,uint256)'](1, 5, 4),
-      ).to.be.revertedWith('PeriodicPCOParamsInternal: invalid fee');
-    });
-
     it('should revert if already initialized', async function () {
       const factory = await ethers.getContractFactory('PeriodicPCOParamsFacet');
       const instance = await factory.deploy();