Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting up the repository for git-collaboration #8

Merged
merged 7 commits into from
Mar 26, 2024
Merged

Setting up the repository for git-collaboration #8

merged 7 commits into from
Mar 26, 2024

Conversation

ns-rse
Copy link
Contributor

@ns-rse ns-rse commented Mar 26, 2024

Decided to extend the python-calculator to work with the Git
Collaboration
course that is being developed.

  • Consolidate functions to arithmetic module
  • Add typehints and numpy doc strings to functions
  • Remove exisiting issue templates
  • Add zero division issue template
  • Add square root issue template
  • Add conventional commit issue template for bug and doc
  • Switch to pyproject.toml for package configuration
  • pylint configuration file
  • Add pre-commit hooks...
    • black
    • codespell
    • ruff
    • markdownlint-cli2
    • mypy
    • numpydoc
    • prettier
    • pylint (local)
    • pyupgrade
  • Parametrise the tests
  • Adds two dummy branches divide and multiply for challenges on switching branches and looking at history

Decided to extend the `python-calculator` to work with the [Git
Collaboration](https://github.com/ns-rse/git-collaboration) course that is being developed.

+ Consolidate functions to `arithmetic` module
+ Add typehints and numpy doc strings to functions
+ Remove exisiting issue templates
+ Add zero division issue template
+ Add square root issue template
+ Switch to `pyproject.toml` for package configuration
+ `pylint` configuration file
+ Add [pre-commit](https://pre-commit.com) hooks...
  + `black`
  + `codespell`
  + `ruff`
  + `markdownlint-cli2`
  + `mypy`
  + `numpydoc`
  + `prettier`
  + `pylint` (local)
  + `pyupgrade`
+ Parametrise the tests
@ns-rse ns-rse merged commit 7fececb into RSE-Sheffield:main Mar 26, 2024
9 checks passed
@ns-rse ns-rse deleted the ns-rse/initial-setup branch March 26, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant