Rocm jaxlib v0.4.30 qa cleanup #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Main changes include: * Added support for fp8 matmul with output data type to be fp8 and bf16. * Added buffer comparators for fp8e4m3fnuz and fp8e5m2fnuz
|
@draganmladjenovic take a look at the failures for MLIR tests at 79b3692 Most of them are failing due to bigger thread size and smaller block size in AMD GPUs compared to NVIDIA. Some tests run into infinite loop on MI200 and hence I have commented out RunAndCompare |
i-chaochen
reviewed
Aug 17, 2024
It needs more investigation. It depends on the choice of autotune https://github.com/ROCm/frameworks-internal/issues/9088 |
hsharsha
force-pushed
the
rocm-jaxlib-v0.4.30-qa-cleanup
branch
from
e1d02ab
to
be97509
Compare
hsharsha
force-pushed
the
rocm-jaxlib-v0.4.30-qa-cleanup
branch
from
dd85325
to
4bc36d5
Compare
hsharsha
force-pushed
the
rocm-jaxlib-v0.4.30-qa-cleanup
branch
from
4bc36d5
to
339dde0
Compare
pemeliya
reviewed
Aug 29, 2024
| switch (algorithm) { | ||
| case PrecisionConfig::ALG_DOT_ANY_F8_ANY_F8_F32: | ||
| case PrecisionConfig::ALG_DOT_ANY_F8_ANY_F8_F32_FAST_ACCUM: | ||
| // Other F8 types are actually not supported by NVIDIA GPUs. | ||
| return is_cuda_ge_ada && | ||
| return (is_cuda_ge_ada || is_rocm_mi100_and_above) && |
There was a problem hiding this comment.
I am not sure if this is really correct. I guess FP8 support begins from MI300 arch? But I see that we have the same check also on upstream
pemeliya
approved these changes
Aug 29, 2024
|
Is this PR merged in QA-31 too? @hsharsha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.