Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable fp64 dynamic slice test #24

Conversation

hsharsha
Copy link

@hsharsha hsharsha commented Jul 1, 2024

This is because AMD does not support MLIR dialect lowering
https://github.com/openxla/xla/blob/main/xla/service/gpu/fusions/fusions.cc#L158-L161

      if (check_mlir_emitters(/*required_level=*/1)) {
        return std::make_unique<MlirLoopFusion>(analysis);
      }
      return std::make_unique<LoopFusion>(analysis);

For NVIDIA it emits std::make_unique<MlirLoopFusion>(analysis) and for AMD std::make_unique<LoopFusion>(analysis)

If we emit std::make_unique<LoopFusion>(analysis) for NVIDIA it also fails with similar signature.

Copy link

@i-chaochen i-chaochen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@i-chaochen i-chaochen merged commit 38d36df into rocm-jaxlib-v0.4.28-qa Jul 2, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants