Sync changes from the tf branch

ROCm · Nov 21, 2024 · cbb3b6f · cbb3b6f
1 parent 6e2d1e0
commit cbb3b6f
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 11 deletions.
diff --git a/build_tools/rocm/run_xla.sh b/build_tools/rocm/run_xla.sh
@@ -55,25 +55,19 @@ UNSUPPORTED_GPU_TAGS="$(echo -requires-gpu-sm{60,70,80,86,89,90}{,-only})"
 TAGS_FILTER="${TAGS_FILTER},${UNSUPPORTED_GPU_TAGS// /,}"
 
 bazel \
-    --output_base="/home/atheodor/projects/xla/bazel-build-dir" \
     test \
-    --sandbox_debug \
-    --verbose_failures \
     --config=rocm \
     --build_tag_filters=${TAGS_FILTER} \
     --test_tag_filters=${TAGS_FILTER} \
     --test_timeout=920,2400,7200,9600 \
     --test_sharding_strategy=disabled \
     --test_output=errors \
-    --flaky_test_attempts=1 \
+    --flaky_test_attempts=3 \
     --keep_going \
     --local_test_jobs=${N_TEST_JOBS} \
     --test_env=TF_TESTS_PER_GPU=$TF_TESTS_PER_GPU \
     --test_env=TF_GPU_COUNT=$TF_GPU_COUNT \
     --action_env=XLA_FLAGS=--xla_gpu_force_compilation_parallelism=16 \
     --action_env=XLA_FLAGS=--xla_gpu_enable_llvm_module_compilation_parallelism=true \
     --run_under=//tools/ci_build/gpu_build:parallel_gpu_execute \
-    -- //xla/tests:dot_operation_test_gpu_amd_any \
-    #-- //xla/...
-    #-- //xla/service/gpu/tests:element_wise_row_vectorization_test_gpu_amd_any \
-
+    -- //xla/...
diff --git a/third_party/tsl/third_party/gpus/rocm/BUILD.tpl b/third_party/tsl/third_party/gpus/rocm/BUILD.tpl
@@ -213,7 +213,8 @@ cc_library(
     strip_include_prefix = "%{rocm_root}",
     visibility = ["//visibility:public"],
     deps = [
-        ":rocm",
+        ":rocm_config",
+        ":rocm_headers",
     ],
 )
 

diff --git a/third_party/tsl/third_party/gpus/rocm_configure.bzl b/third_party/tsl/third_party/gpus/rocm_configure.bzl
@@ -573,6 +573,7 @@ def _setup_rocm_distro_dir(repository_ctx):
         return _get_rocm_config(repository_ctx, bash_bin, _DISTRIBUTION_PATH + "/" + redist["rocm_root"])
     else:
         rocm_path = repository_ctx.os.environ.get(_ROCM_TOOLKIT_PATH, _DEFAULT_ROCM_TOOLKIT_PATH)
+        repository_ctx.report_progress("Using local rocm installation {}".format(rocm_path))  # buildifier: disable=print
         repository_ctx.symlink(rocm_path, _DISTRIBUTION_PATH)
         return _get_rocm_config(repository_ctx, bash_bin, _DISTRIBUTION_PATH)
 

diff --git a/xla/service/gpu/kernels/BUILD b/xla/service/gpu/kernels/BUILD
@@ -174,8 +174,6 @@ gpu_kernel_library(
         "//xla:types",
         "//xla/stream_executor/gpu:gpu_types_header",
         "@tsl//tsl/lib/math:math_util",
-    ] + if_rocm_is_configured([
-        "@local_config_rocm//rocm:rocm",
     ]),
 )