-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GQA and KV Cache #1696
Open
dhernandez0
wants to merge
8
commits into
develop
Choose a base branch
from
1655-groupqueryattention-with-kv-cache
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add GQA and KV Cache #1696
+1,112
−68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhernandez0
changed the title
Add GQA support for rocmlir-gen and add GQA tests
Add GQA and KV Cache
Nov 20, 2024
umangyadav
reviewed
Nov 25, 2024
umangyadav
approved these changes
Nov 26, 2024
dhernandez0
force-pushed
the
1655-groupqueryattention-with-kv-cache
branch
from
November 28, 2024 12:25
0f3912b
to
b84f77d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1696 +/- ##
===========================================
+ Coverage 78.22% 78.25% +0.02%
===========================================
Files 100 100
Lines 28009 28346 +337
Branches 4097 4130 +33
===========================================
+ Hits 21910 22182 +272
- Misses 4434 4484 +50
- Partials 1665 1680 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for:
Note that MIGraphX integration will be done in a next ticket (we need to sync with them to decide how to do this). So, for now, TosaToRock sets currentSeqLen = nullptr.