ROCm 6.0 replaces all __HIP_PLATFORM_HCC__ with __HIP_PLATFORM_AMD__ #1106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junliume
commented
Dec 19, 2023
CMakeLists.txt
Outdated
| @@ -243,7 +243,7 @@ if( DEFINED CK_OVERRIDE_HIP_VERSION_PATCH ) | |||
| endif() | |||
| message(STATUS "Build with HIP ${HIP_VERSION}") | |||
| link_libraries(hip::device) | |||
| add_compile_definitions(__HIP_PLATFORM_HCC__=1) | |||
| add_compile_definitions(__HIP_PLATFORM_AMD__=1) | |||
There was a problem hiding this comment.
We need to find a way to make this backward compatible
illsilin
approved these changes
Dec 19, 2023
atamazov
reviewed
Dec 19, 2023
Comment on lines
+246
to
+250
| if(CK_hip_VERSION VERSION_GREATER_EQUAL 6.0.23494) | ||
| add_compile_definitions(__HIP_PLATFORM_AMD__=1) | ||
| else() | ||
| add_compile_definitions(__HIP_PLATFORM_HCC__=1) | ||
| endif() |
There was a problem hiding this comment.
There was a problem hiding this comment.
@illsilin could we remove them? Since CK uses offline compiler at the moment. Or this is noop and will not have any effects.
There was a problem hiding this comment.
I don't think we use those macros in CK, so it makes no difference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: ROCm/MIOpen#2617 (comment)