Revert "SWDEV-365820 - Refactor build path" #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3f2f725. Reason: it breaks -save-temps in OpenCL See bug report: ROCm/ROCm#2940
preda
requested review from
chrispaquot,
gandryey,
saleelk,
mangupta and
rakesroy
as code owners
|
Any reviewer's comments? |
|
@saleelk hey guys are you serious? your change broke your project, the breakage affects your users, it's a bug, it's been months. Why aren't you reverting the breakage, and take the time to think about the right way to do it without keeping things broken. What are you waiting for? no review yet for the revert -- out of reviewers maybe? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 3f2f725.
Reason: it breaks -save-temps in OpenCL
See bug report: ROCm/ROCm#2940