-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suppress MLIR ubsan errors #3198
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep track of this WA and minimize the fix later:
shared_ptr_base.h
@junliume maybe we can simply disable MLIR in the failing stage as a W/A? |
I think that could also be a reasonable workaround, but not sure which way we prefer. |
I slightly prefer @atamazov 's suggestion because currently we're saying all best are off with |
I can update this to instead turn off MLIR for the debug steps. @junliume that good with you? |
I think disabling MLIR for the sanitized steps as Artem suggested is less harmful because it is at least somewhat tested anyway and we would really not want to miss some shared_ptr misuse in the library if that would happen. |
@BrianHarrisonAMD yes let's do it by only disabling checks when MLIR is in use. Thanks! |
Sounds good! Ill close and make a new PR with disabling MLIR for the sanitize steps. Thanks for the feedback everyone! |
Add suppressing ubsan errors for the file shared_ptr_base.h to workaround errors when upgrading to ROCm 6.2 in the base docker.
See relevant PR #3181, and Issue #3192 for additional details.
The issue can be tracked down to simply creating the MLIR handle after upgrading to the latest ROCm 6.2.
Since we froze MLIR to an older release, suppressing this warning is our only real option.
Note: