Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hipRTC] Fix conflicting workaround with updated hipRTC #2615

Closed
wants to merge 6 commits into from

Conversation

junliume
Copy link
Collaborator

No description provided.

@junliume
Copy link
Collaborator Author

junliume commented Dec 18, 2023

@atamazov FYI

CI still fails with Fp32 Hip AnyGPU

[2023-12-18T09:51:31.104Z]   40/1760 Test   #42: test_reduce_test ........................................................................................................................................................................................................................................................................................................................................................................................................***Failed  Error regular expression found in output. Regex=[FAILED]  1.89 sec
[2023-12-18T09:51:31.104Z] PRNG seed: 12345678
[2023-12-18T09:51:31.104Z] MIOpen(HIP): Error [Compile] 'hiprtcCompileProgram(prog.get(), c_options.size(), c_options.data())' gridwise_generic_reduction_first_call_threadwise_reduce_partial_dims.cpp: HIPRTC_ERROR_COMPILATION (6)
[2023-12-18T09:51:31.105Z] MIOpen(HIP): Error [BuildHip] HIPRTC status = HIPRTC_ERROR_COMPILATION (6), source file: gridwise_generic_reduction_first_call_threadwise_reduce_partial_dims.cpp
[2023-12-18T09:51:31.105Z] MIOpen(HIP): Warning [BuildHip] In file included from /tmp/comgr-c9c33f/input/gridwise_generic_reduction_first_call_threadwise_reduce_partial_dims.cpp:28:
[2023-12-18T09:51:31.105Z] In file included from /tmp/comgr-c9c33f/include/sequence.hpp:5:
[2023-12-18T09:51:31.105Z] /tmp/comgr-c9c33f/include/type.hpp:101:42: error: no type named 'remove_reference' in namespace 'std'
[2023-12-18T09:51:31.105Z] using remove_reference_t = typename std::remove_reference<T>::type;
[2023-12-18T09:51:31.105Z]                            ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~

@atamazov
Copy link
Contributor

@junliume What is the issue this PR is intended to fix?

@atamazov
Copy link
Contributor

@junliume No need to answer, I see, thanks.

@junliume
Copy link
Collaborator Author

replaced by #2637

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants