-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update _toc.yml.in #2587
Update _toc.yml.in #2587
Changes from all commits
6d2ae15
856b2f1
cae46fd
709164f
0832e53
cac7a88
79970e0
f7a771b
3c5e83c
4068655
d0bc0f0
4252d7c
ad34523
be715eb
ef2a85b
29005e8
8473e31
7acfd67
b7c73a5
7064c40
8de1cf5
1ca42e6
8e47f79
07dd95b
523dd5c
b36bd8c
e745fe9
30d9b49
0ebea5e
ca4c03b
70ee48c
759eb1d
a2c18ca
f5f9f25
7f29f72
29d889b
a98c179
b136967
9468d39
bae376f
83a7bad
b4130e0
3a194ee
bc5e196
cc59168
c516a26
e26621d
2ec2460
1762b8b
df8b27d
71f26d3
671a10c
40f2468
98c702e
3cf98ef
0ffdf18
6af3b71
64d6b3a
e75956f
e79fa33
054b3d1
d3cc79b
bd1c96d
880be0b
4eb7f47
888eb7c
286b8d7
6517398
1376bdb
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
.. _apireference: | ||
|
||
API Reference | ||
============= | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
Indices and tables | ||
======== | ||
.. toctree:: | ||
:maxdepth: 2 | ||
:caption: Contents: | ||
|
||
:ref:`what-is-MIOpen` | ||
:ref:`install` | ||
:ref:`apireference` |
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. where is the API ref heading? you seem to have removed the entire former API ref section and there is no organization to the existing pages There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. look at the build--it's not rendering, so you need to fix the code. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yep. It's a work in progress. Won't render yet. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. you haven't added any of the Doxygen content (=the API ref) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Doxygen builds content automatically from the header files (which contains the code/text/content for the API). The team does does not supply the API textual content. This content is build into the "Doxygen" folder--this is what you need to include in the toc in order to incorporate the API ref. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,24 +1,57 @@ | ||
# Anywhere {branch} is used, the branch name will be substituted. | ||
# These comments will also be removed. | ||
defaults: | ||
numbered: False | ||
maxdepth: 6 | ||
maxdepth: 7 | ||
root: index | ||
subtrees: | ||
- entries: | ||
- file: releasenotes | ||
- file: citation | ||
- file: install | ||
- file: embed | ||
- file: driver | ||
- file: DebugAndLogging | ||
- file: cache | ||
- file: perfdatabase | ||
- file: finddb | ||
- file: find_and_immediate | ||
- file: Getting_Started_FusionAPI | ||
- file: MI200AlternateImplementation | ||
- file: MIOpen_Porting_Guide | ||
- file: apireference | ||
- caption: About | ||
entries: | ||
- file: license | ||
- caption: What is MIOpen? | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this should not be a heading. it should be an intro page that describes the project. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We are still discussing the content for the Intro page. For now, we have reorganized the ToC on what's available and accurate. We have also removed the reference to release notes, as it is obsolete. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. then we need to wait until we have a page to link to. It's confusing to have a heading represent a placeholder for a future page. A heading (='caption' in the toc) should only be there to represent pages that fit into that heading. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That's a decision we must make. Working with the team. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. you can use the README file to get a little general info for a 'What is ..?' page until the team gets a chance to add to it. this page doesn't need to super long or elaborate, just has to describe what the project is/does. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks, Lisa. Thanks so much for your help and comments. |
||
subtrees: | ||
- entries: | ||
- file: tutorials/what-is-MIOpen.rst | ||
title: What is MIOpen? | ||
- file: tutorials/find_and_immediate.rst | ||
title: Find and Immediate | ||
- file: tutorials/finddb.rst | ||
title: Find database | ||
- file: tutorials/cache.rst | ||
title: Cache | ||
- file: tutorials/perfdatabase.rst | ||
title: Performance database | ||
- file: tutorials/Getting_Started_FusionAPI.rst | ||
title: Getting started with Fusion API | ||
- file: tutorials/DebugAndLogging.rst | ||
title: Debugging and logging | ||
- file: tutorials/MI200AlternateImplementation.rst | ||
title: Alternate implementation for MI200 | ||
- file: tutorials/MIOpen_Porting_Guide.rst | ||
title: MIOpen Porting Guide | ||
|
||
- file: tutorials/index.rst | ||
- caption: Quick-start | ||
subtrees: | ||
- entries: | ||
- file: tutorials/quick-start/install.rst | ||
title: MIOpen installation | ||
- file: tutorials/quick-start/embed.rst | ||
title: Embedding MIOpen | ||
- file: tutorials/quick-start/driver.rst | ||
title: About MIOpen driver | ||
|
||
- file: reference/index.rst | ||
- caption: API reference | ||
subtrees: | ||
- entries | ||
- file: reference/apireference.rst | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You're referencing a lot of files/folders that don't exit...and need to include the API ref from the doxygen folder (see my previous comment). There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Bibek and I added the API ref from the Doxygen folder. @bghimireamd Please advise. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Exit? or Exist? We have reused all existing and original files. Sam recommended we create the appropriate folders, and as suggested, we used hipSPARSElt as the template. Should we remove the titles and keep it simple for 6.0? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. that was a typo: I meant exist. |
||
title: API library | ||
|
||
- file: tutorials/index.rst | ||
- caption: Tutorials | ||
subtrees: | ||
- entries: | ||
- file: tutorials/install.rst | ||
title: MIOpen installation | ||
- file: tutorials/embed.rst | ||
title: Embedding MIOpen | ||
- file: tutorials/driver.rst | ||
title: Installing and building MIOpen | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,3 @@ | ||
|
||
# MIOpen Porting Guide | ||
|
||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,3 @@ | ||
|
||
Building MIOpen for Embedded Systems | ||
==================================== | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,62 @@ | ||
.. _install: | ||
|
||
Building MIOpen from source | ||
~~~~~~~~~~ | ||
|
||
Configuring with cmake | ||
---------- | ||
|
||
First create a build directory: | ||
|
||
.. code-block:: bash | ||
|
||
mkdir build; cd build; | ||
|
||
|
||
Next configure cmake. The preferred backend for MIOpen can be set using the `-DMIOPEN_BACKEND` cmake variable. | ||
|
||
For the HIP backend (ROCm 3.5 and later), run | ||
---------- | ||
|
||
Set the C++ compiler to `clang++`. | ||
|
||
.. code-block:: bash | ||
|
||
export CXX=<location-of-clang++-compiler> | ||
cmake -DMIOPEN_BACKEND=HIP -DCMAKE_PREFIX_PATH="<hip-installed-path>;<rocm-installed-path>;<miopen-dependency-path>" .. | ||
|
||
An example cmake step can be: | ||
|
||
.. code-block:: bash | ||
|
||
export CXX=/opt/rocm/llvm/bin/clang++ && \ | ||
cmake -DMIOPEN_BACKEND=HIP -DCMAKE_PREFIX_PATH="/opt/rocm/;/opt/rocm/hip;/root/MIOpen/install_dir" .. | ||
|
||
Note: When specifying the path for the `CMAKE_PREFIX_PATH` variable, **do not** use the `~` shorthand for the user home directory. | ||
|
||
|
||
Setting Up Locations | ||
---------- | ||
|
||
By default the install location is set to '/opt/rocm', this can be set by using `CMAKE_INSTALL_PREFIX`: | ||
|
||
.. code-block:: bash | ||
|
||
cmake -DMIOPEN_BACKEND=OpenCL -DCMAKE_INSTALL_PREFIX=<miopen-installed-path> .. | ||
|
||
Building MIOpen using docker | ||
~~~~~~~~~~ | ||
|
||
The easiest way is to use docker. You can build the top-level docker file: | ||
|
||
.. code-block:: bash | ||
|
||
docker build -t miopen-image . | ||
|
||
Then to enter the development environment use `docker run`, for example: | ||
|
||
.. code-block:: bash | ||
|
||
docker run -it -v $HOME:/data --privileged --rm --device=/dev/kfd --device /dev/dri:/dev/dri:rw --volume /dev/dri:/dev/dri:rw -v /var/lib/docker/:/var/lib/docker --group-add video --cap-add=SYS_PTRACE --security-opt seccomp=unconfined miopen-image | ||
|
||
Prebuilt docker images can be found on [ROCm's public docker hub here](https://hub.docker.com/r/rocm/miopen/tags). |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
.. meta:: | ||
:description: MIOpen is AMD’s deep learning primitives library, which provides highly optimized, and hand-tuned implementations of | ||
different operators such as convolution, batch normalization, pooling, softmax, activation and layers for Recurrent Neural | ||
Networks (RNNs), used in both training and inference [9]. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please remove the reference. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I did. Let me resend the PR. Here's the final text, MIOpen is AMD’s deep learning primitives library, which provides highly optimized and hand-tuned implementations of different operators such as convolution, batch normalization, pooling, softmax, activation and layers for Recurrent Neural Networks (RNNs), used in both training and inference. Moreover, MIOpen is fully open source, including all its GPU kernels, complementing AMD’s open source ROCm stack. MIOpen is the first to extend the open source advantage into GPU vendor libraries thereby, continuing to embark on the same ethos as the deep learning community. |
||
:keywords: MIOpen, ROCm, library, API | ||
|
||
.. _what-is-MIOpen: | ||
|
||
********************* | ||
What is MIOpen? | ||
********************* | ||
|
||
MIOpen is AMD’s deep learning primitives library, which provides highly optimized and hand-tuned implementations of different operators such as convolution, batch normalization, pooling, softmax, activation and layers for Recurrent Neural Networks (RNNs), used in both training and inference. Moreover, MIOpen is fully open source, including all its GPU kernels, complementing AMD’s open source ROCm stack. MIOpen is the first to extend the open source advantage into GPU vendor libraries thereby, continuing to embark on the same ethos as the deep learning community. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samjwu is this change correct?