Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove FIN_OLD_PROBLEM_DESCRIPTION_COMPAT #2503

Merged
merged 15 commits into from
Dec 19, 2023
Merged

Remove FIN_OLD_PROBLEM_DESCRIPTION_COMPAT #2503

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
f5b693b
Remove FIN_OLD_PROBLEM_DESCRIPTION_COMPAT
averinevg Nov 3, 2023
39ca334
Temporary switch fin branch
averinevg Nov 3, 2023
6d13c3c
Merge branch 'develop' into ea_remove_fin_old_problem_description_compat
junliume Nov 10, 2023
6e8457b
Merge branch 'develop' into ea_remove_fin_old_problem_description_compat
averinevg Nov 14, 2023
905d8de
Merge branch 'ea_remove_fin_old_problem_description_compat' of https:…
averinevg Nov 14, 2023
4a61a1a
Update fin branch
averinevg Nov 14, 2023
52bea37
Update fin branch
averinevg Nov 14, 2023
f0d55be
Merge branch 'develop' into ea_remove_fin_old_problem_description_compat
averinevg Dec 1, 2023
aa49069
Merge branch 'develop' into ea_remove_fin_old_problem_description_compat
averinevg Dec 4, 2023
6cb3384
Fix layernorm
averinevg Dec 5, 2023
3f7db52
Fix formatting
averinevg Dec 5, 2023
10939f5
Merge branch 'develop' into ea_remove_fin_old_problem_description_compat
averinevg Dec 13, 2023
41b3695
Merge branch 'develop' into ea_remove_fin_old_problem_description_compat
averinevg Dec 14, 2023
d94b601
Merge branch 'develop' into ea_remove_fin_old_problem_description_compat
averinevg Dec 15, 2023
927c148
Merge branch 'develop' into ea_remove_fin_old_problem_description_compat
averinevg Dec 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fin
Open in desktop
Submodule fin updated from ae2ff1 to 044f5e
23 changes: 0 additions & 23 deletions src/include/miopen/problem_description.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,6 @@
#include <cstdint>
#include <string>

#define FIN_OLD_PROBLEM_DESCRIPTION_COMPAT 1

namespace miopen {

// Tensor Helper APIs
Expand All @@ -57,27 +55,6 @@ SetDescFromMLDesc(int spatial_dims, TTo& to, const TensorDescriptor& tensor, con
return tensor.GetElementSpace();
}

#if FIN_OLD_PROBLEM_DESCRIPTION_COMPAT
struct ProblemDescription : conv::ProblemDescription
{
ProblemDescription() = default;

ProblemDescription(conv::ProblemDescription desc) : conv::ProblemDescription(std::move(desc))
{
conv_problem.p = this;
}

struct
{
void SetupFloats(ExecutionContext& ctx) const { p->SetupFloats(ctx); }

private:
const conv::ProblemDescription* p = nullptr;
friend struct ProblemDescription;
} conv_problem;
};
#endif

// For mlo_construct_base
// TODO remove this
struct ProblemDescriptionCompatTemporary
Expand Down