Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add multi device management #3664

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Add multi device management #3664

merged 1 commit into from
Nov 22, 2024

Conversation

matyas-streamhpc
Copy link

No description provided.

@matyas-streamhpc matyas-streamhpc self-assigned this Nov 7, 2024
@neon60 neon60 marked this pull request as ready for review November 15, 2024 12:49
randyh62
randyh62 approved these changes Nov 16, 2024
View reviewed changes
Copy link

@randyh62 randyh62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments. Looks good overall.

docs/how-to/hip_runtime_api/multi_device.rst Show resolved Hide resolved
docs/how-to/hip_runtime_api/multi_device.rst Outdated Show resolved Hide resolved
docs/how-to/hip_runtime_api/multi_device.rst Outdated Show resolved Hide resolved
docs/how-to/hip_runtime_api/multi_device.rst Outdated Show resolved Hide resolved
docs/how-to/hip_runtime_api/multi_device.rst Outdated Show resolved Hide resolved
@neon60 neon60 requested a review from randyh62 November 18, 2024 16:05
randyh62
randyh62 approved these changes Nov 18, 2024
View reviewed changes
Copy link

@randyh62 randyh62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments

docs/how-to/hip_runtime_api/multi_device.rst Show resolved Hide resolved
docs/how-to/hip_runtime_api/multi_device.rst Show resolved Hide resolved
docs/how-to/hip_runtime_api/multi_device.rst Show resolved Hide resolved
docs/how-to/hip_runtime_api/multi_device.rst Show resolved Hide resolved
docs/how-to/hip_runtime_api/multi_device.rst Show resolved Hide resolved
docs/how-to/hip_runtime_api/multi_device.rst Show resolved Hide resolved
@neon60 neon60 deleted the branch docs/develop November 18, 2024 17:39
@neon60 neon60 closed this Nov 18, 2024
@neon60 neon60 reopened this Nov 18, 2024
@neon60 neon60 changed the base branch from hip_runtime_api_how-to to docs/develop November 18, 2024 17:43
@neon60 neon60 force-pushed the multi-device branch 3 times, most recently from 5079db7 to d7bb727 Compare November 19, 2024 18:19
@neon60 neon60 requested a review from randyh62 November 20, 2024 22:12
randyh62
randyh62 approved these changes Nov 21, 2024
View reviewed changes
Copy link

@randyh62 randyh62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@g-h-c
Copy link

g-h-c commented Nov 22, 2024

The device enumeration section is perhaps slightly imprecise when it comes to systems that have both AMD and Nvidia GPUs, because the HIP runtime cannot see both at the same time, yet the page says: "The host queries the system to count and list all connected GPUs,"
A binary using HIP compiled with HIP_PLATFORM=amd will only see amd devices, and with HIP_PLATFORM=nvidia only Nvidia; or at least that is what I experience when I run it on my hybrid system.

@matyas-streamhpc
Copy link
Author

The device enumeration section is perhaps slightly imprecise when it comes to systems that have both AMD and Nvidia GPUs, because the HIP runtime cannot see both at the same time, yet the page says: "The host queries the system to count and list all connected GPUs," A binary using HIP compiled with HIP_PLATFORM=amd will only see amd devices, and with HIP_PLATFORM=nvidia only Nvidia; or at least that is what I experience when I run it on my hybrid system.

Thank you, it's a nice catch! Updated.

@neon60 neon60 merged commit c28e077 into docs/develop Nov 22, 2024
3 of 4 checks passed
@neon60 neon60 deleted the multi-device branch November 25, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@randyh62 randyh62 randyh62 approved these changes

@neon60 neon60 neon60 approved these changes

@chrispaquot chrispaquot Awaiting requested review from chrispaquot chrispaquot is a code owner

@gandryey gandryey Awaiting requested review from gandryey gandryey is a code owner

@saleelk saleelk Awaiting requested review from saleelk saleelk is a code owner

@mangupta mangupta Awaiting requested review from mangupta mangupta is a code owner

@rakesroy rakesroy Awaiting requested review from rakesroy rakesroy is a code owner

Assignees

@matyas-streamhpc matyas-streamhpc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matyas-streamhpc @g-h-c @neon60 @randyh62