Fix "txpacket() randomly gets stuck on Linux" #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turned out that Python SDK calls termios.tcdrain() to clear remaining data in the serial port. Since tcdrain() is a blocking operation, it can paralyze the Python interpreter execution for a few seconds. On the other hand, C/C++ SDK uses `tcflush()` for the same purpose, so simply dicards the data not transmitted yet. Fix Python SDK to do the same. Signed-off-by: Fujimoto Seiji <[email protected]>
|
@robotpilot I'm wondering why this PR gets closed? We've been using a forked version for this issue. It would |
|
@fujimotos I'm sorry for the unintended situation. This issue arose as we switched the default branch from "master" to "main." If you could modify the PR to target the "main" branch or re-register it, we will make sure to reflect it in the upcoming update. We apologize for the inconvenience and thank you for your understanding. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue "Python SDK randomly gets stuck on txpacket()".
termios.tcdrain()to clear remainingdata in the serial port.
tcdrain()is a blocking operation, it can paralyze the Pythoninterpreter for a few seconds.
On the other hand, C/C++ SDK uses
tcflush()for the same purpose, sosimply dicards the data not transmitted yet. Fix Python SDK to do the same.
Related: See pyserial/pyserial#625 for related discussion in pyserial/pyserial.