WIP: added nested function (fixes #2) #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this still require changes? |
|
I think that the example is correct, but also there's a bug in the parser RMLio/yarrrml-parser#68 |
bjdmeest
changed the title
|
The bug is in the RMLMapper instead RMLio/rmlmapper-java#53 |
|
I guess we still can merge it based on the RMLMapper issue, right? @bjdmeest |
|
well, I can just imagine people seeing and trying this example and then seeing it doesn't work, which might be confusing, I'd personally keep it open until the issue is fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.