Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collect signatures from the stash #232

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

cymqqqq
Copy link
Contributor

@cymqqqq cymqqqq commented Jul 1, 2024

Description:

  1. Add sigs_for in the stash reader provider
  2. Collect genesis, scheme, iface, and iimpl signatures from the stash provider

Questions: I don't understand the following TODO

  1. Conceal everything we do not need. (conceal seal, transition, and state?)
  2. Add known sigs to the consignment. (What's the difference from the collect signatures from the stash?)

And the know sigs, do you mean the content signatures from the stash or the signatures from the disclosure? (In the Disclosure, there is PublicKey, Signature Key-Value map).

Copy link

codecov bot commented Jul 1, 2024

Codecov Report

Attention: Patch coverage is 42.50000% with 23 lines in your changes missing coverage. Please review.

Project coverage is 20.5%. Comparing base (7f637c6) to head (5a0d3f4).
Report is 5 commits behind head on master.

Files Patch % Lines
src/persistence/stock.rs 28.1% 23 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master    #232     +/-   ##
========================================
+ Coverage    17.6%   20.5%   +3.0%     
========================================
  Files          37      37             
  Lines        7535    7666    +131     
========================================
+ Hits         1323    1574    +251     
+ Misses       6212    6092    -120     
Flag Coverage Δ
rust 20.5% <42.5%> (+3.0%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dr-orlovsky dr-orlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 5a0d3f4

@dr-orlovsky dr-orlovsky added this to the v0.11.0 milestone Jul 2, 2024
@dr-orlovsky dr-orlovsky merged commit 62a91ff into RGB-WG:master Jul 2, 2024
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants