collect supplements in issue contract

[cymqqqq]

Description:

add collect supplements feature for the issue_contract, includes the following Supplement instance:

genesis supplement
iface supplement
iimpl supplement
schema supplement

[codecov]

Codecov Report

Attention: Patch coverage is 50.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 18.1%. Comparing base (7f637c6) to head (e599ba1).
Report is 1 commits behind head on master.

Files	Patch %	Lines
src/interface/builder.rs	50.0%	8 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##           master    #231     +/-   ##
========================================
+ Coverage    17.6%   18.1%   +0.6%     
========================================
  Files          37      37             
  Lines        7535    7548     +13     
========================================
+ Hits         1323    1369     +46     
+ Misses       6212    6179     -33     

Flag	Coverage Δ
rust	18.1% <50.0%> (+0.6%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dr-orlovsky]

You can just do

supplements: confined_bset![
   Supplement::new(ContentRef::Schema(schema.schema_id()), schema.developer.clone()),
    ...
]

[dr-orlovsky]

Why are you merging master? Just do rebases

[cymqqqq]

Sorry....I always use the update branch button, next time I'll try to git rebase main.

[dr-orlovsky]

Sorry, just understood that in this PR instead of gathering supplements from the stash you create some pseudo-supplements out of arbitrary cosnensus data.

Approach NACK. Please either collect supplements from the stash - or close the PR

[cymqqqq]

I agree with you, the first idea is to collect supplements from the stash, but the question is: do we have a stash when we issue a contract? (In the consign method, yes, there is already a stash so we can collect supplements from the stash.) I just found ContractBuilder, and after we finish the contract issue, then initialize a stock(MemStash, MemState, and MemIndex), and then we can import the kit and contract to the stash.

[dr-orlovsky]

When you issue contract you need to collect just supplements for interfaces, schema and implementation. There is no "genesis supplement" which can be found in the stash.

You also need to keep in mind that right now there is no supplements which exist - this functionality is there only as a way to add new things in the future.