Validation: check that all actual witness ids match the expected value #262

dr-orlovsky · 2024-07-22T21:26:18Z

Addresses #261

src/validation/validator.rs

zoedberg

tACK 464ddf8

But before merging this I would fix the typo found by @St333p

Co-authored-by: Stefano Pellegrini <[email protected]>

validation: check that all actual witness ids match the expected value

464ddf8

dr-orlovsky added the bug Something isn't working label Jul 22, 2024

dr-orlovsky added this to the v0.11.0 milestone Jul 22, 2024

dr-orlovsky requested a review from zoedberg July 22, 2024 21:26

dr-orlovsky self-assigned this Jul 22, 2024

dr-orlovsky mentioned this pull request Jul 22, 2024

consignment validation succeeds despite changed txid in bundle pubWitness #261

Closed

St333p reviewed Jul 23, 2024

View reviewed changes

src/validation/validator.rs Outdated Show resolved Hide resolved

zoedberg previously approved these changes Jul 23, 2024

View reviewed changes

dr-orlovsky dismissed zoedberg’s stale review via 4ac2692 July 23, 2024 14:34

validate: doc fix typo in witness resolver error

4ac2692

Co-authored-by: Stefano Pellegrini <[email protected]>

dr-orlovsky merged commit 60377cf into master Jul 23, 2024
20 checks passed

dr-orlovsky mentioned this pull request Jul 24, 2024

Avoid possible mismatches between witness txid and tx data at type system level RGB-WG/rgb-std#239

Merged

dr-orlovsky deleted the validity branch September 4, 2024 21:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Validation: check that all actual witness ids match the expected value #262

Validation: check that all actual witness ids match the expected value #262

dr-orlovsky commented Jul 22, 2024

zoedberg left a comment

Validation: check that all actual witness ids match the expected value #262

Validation: check that all actual witness ids match the expected value #262

Conversation

dr-orlovsky commented Jul 22, 2024

zoedberg left a comment

Choose a reason for hiding this comment