Refactor validation status to match all other API changes #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoedberg
requested changes
Jul 17, 2024
There was a problem hiding this comment.
This PR somehow breaks issuance. Now the call builder.issue_contract (where builder is a ContractBuilder) fails with the following error:
ContractInconsistency(Status { failures: [], warnings: [], info: [] })
Checkout to https://github.com/zoedberg/rgb-integration-tests/tree/validity (and remember to update submodules) to see the issue (run cargo test --test issuance issue_nia::case_1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #259, #254
With the recent clarification on the use of resolvers and consignment-stored transaction ("public witness") information (see RCP-240313A for the details) there is no reason to provide separate fields listing unresolved transaction/witnesses - they all can be retrieved from
Failure::SealNoPubWitnessvariants when iterating overfailuresvector.I also moved
UncheckableConfidentialStatefrominfotowarning(since it is the client who needs to decide whether this is important) and removed unused warning variant.