-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensuring 1-to-1 match of seal closing method with bundles #229
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dr-orlovsky
added
bug
Something isn't working
refactoring
Code refactoring
*consensus*
Issues affecting distributed concensus
*security*
Issues affecting safety/security (include undefined behaviours)
labels
Apr 4, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v0.11 #229 +/- ##
=======================================
+ Coverage 14.1% 14.8% +0.7%
=======================================
Files 33 30 -3
Lines 4149 3794 -355
=======================================
- Hits 585 560 -25
+ Misses 3564 3234 -330
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
*consensus*
Issues affecting distributed concensus
refactoring
Code refactoring
*security*
Issues affecting safety/security (include undefined behaviours)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This disallows assignments to the same UTXO with conflicting closing methods (tapret+opret) since one type of them will be lost. However this fixes a potential attack where opret and tapret anchors are both present committing to different bundles inside the same witness transaction