Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensuring 1-to-1 match of seal closing method with bundles #229

Closed
wants to merge 17 commits into from

Conversation

dr-orlovsky
Copy link
Member

@dr-orlovsky dr-orlovsky commented Apr 4, 2024

This disallows assignments to the same UTXO with conflicting closing methods (tapret+opret) since one type of them will be lost. However this fixes a potential attack where opret and tapret anchors are both present committing to different bundles inside the same witness transaction

@dr-orlovsky dr-orlovsky changed the base branch from master to v0.11 April 4, 2024 11:06
@dr-orlovsky dr-orlovsky requested review from nicbus and zoedberg April 4, 2024 11:06
@dr-orlovsky dr-orlovsky self-assigned this Apr 4, 2024
@dr-orlovsky dr-orlovsky added bug Something isn't working refactoring Code refactoring *consensus* Issues affecting distributed concensus *security* Issues affecting safety/security (include undefined behaviours) labels Apr 4, 2024
@dr-orlovsky dr-orlovsky added this to the v0.11.0 milestone Apr 4, 2024
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 43 lines in your changes are missing coverage. Please review.

Project coverage is 14.8%. Comparing base (94f8691) to head (fb08fb6).
Report is 25 commits behind head on v0.11.

Files Patch % Lines
src/contract/anchor.rs 0.0% 22 Missing ⚠️
src/validation/validator.rs 0.0% 21 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           v0.11    #229     +/-   ##
=======================================
+ Coverage   14.1%   14.8%   +0.7%     
=======================================
  Files         33      30      -3     
  Lines       4149    3794    -355     
=======================================
- Hits         585     560     -25     
+ Misses      3564    3234    -330     
Flag Coverage Δ
rust 14.8% <0.0%> (+0.7%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dr-orlovsky
Copy link
Member Author

Closing in favor of #230 #231 #232 #233

@dr-orlovsky dr-orlovsky closed this Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working *consensus* Issues affecting distributed concensus refactoring Code refactoring *security* Issues affecting safety/security (include undefined behaviours)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant