Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing binding methods #49

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

tmalahie
Copy link
Contributor

@tmalahie tmalahie commented Oct 6, 2024

This PR allows to expose a few more methods to the list of bindings. I'm currently integrating RGB to a wallet in node.js and I need them on order to benefit of all the features. Related PR in nodejs repo: RGB-Tools/rgb-lib-nodejs#1
The methods include:

  • get public key data from mnemonic
  • get BTC balance
  • list BTC transactions
  • Transfer BTC
  • Get asset balance
  • List asset transactions

Let me know if you have questions or remarks on my changes!

Copy link
Collaborator

@zoedberg zoedberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Please sort the methods in alphabetic order, remove empty lines inside methods and sign your commit with gpg

bindings/c-ffi/src/utils.rs Outdated Show resolved Hide resolved
@tmalahie tmalahie force-pushed the binding-additions branch 2 times, most recently from 94857e3 to 3936c72 Compare October 7, 2024 20:23
@tmalahie tmalahie requested a review from zoedberg October 7, 2024 21:41
Copy link
Collaborator

@zoedberg zoedberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you :)

@zoedberg zoedberg merged commit 1d467a8 into RGB-Tools:master Oct 8, 2024
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants