fix: Ignore NS dedicated server for game running check #562
Conversation
Only count Northstar as running if it's not a dedicated server.
GeckoEidechse
changed the title
There was a problem hiding this comment.
Many thanks for the PR <3
I enabled CI and it failed clippy check. The fix should be explained in CI logs.
If you have any questions, LMK ^^
There was a problem hiding this comment.
So in quick testing on Windows, this cause non-dedicated-Northstar to be detected as running.
Both when starting first a dedi server and then client, and when only starting a client.
Not quite sure what's causing that cause looking at the code it should be fine?
Co-authored-by: GeckoEidechse <[email protected]>
…ghtCore into dedicated-server-fix
|
The |
|
Nope, looks like it still has the same issue... :/
Did it work for you locally? |
|
Works fine for me on Linux, could you run a quick test to see what |
| let mut s = sysinfo::System::new_all(); | ||
| s.refresh_all(); | ||
| for process in s.processes().values() { | ||
| if (process.name().ends_with("Titanfall2.exe") || process.name().ends_with("Northstar.exe")) |
There was a problem hiding this comment.
Related to #562 (comment) I think, process name was changed in this PR while it shouldn't have been modified:
| if (process.name().ends_with("Titanfall2.exe") || process.name().ends_with("Northstar.exe")) | |
| if (process.name().ends_with("Titanfall2.exe") || process.name().ends_with("NorthstarLauncher.exe")) |
check_northstar_running()only returns true if Northstar wasn't launched with the-dedicatedflag, untested on Windows.Closes #284