-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev: Packages #429
Draft
GeckoEidechse
wants to merge
42
commits into
main
Choose a base branch
from
dev/packages
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
dev: Packages #429
Changes from all commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
9c0e479
feat: Initial support for reading NS packages dir
GeckoEidechse 008e31e
Merge branch 'main' into feat/read-packages-dir
GeckoEidechse babb502
chore: Code cleanup
GeckoEidechse 58b8dce
Merge branch 'main' into feat/read-packages-dir
GeckoEidechse 7e301bd
feat: Add ability to delete a Thunderstore package
GeckoEidechse 0fc68de
fix: Formatting
GeckoEidechse 0cd98b6
Merge branch 'main' into feat/read-packages-dir
GeckoEidechse 6d0d813
feat: Initial support for installing packages
GeckoEidechse 24090dd
feat: Give wrong version number on legacy TS mods
GeckoEidechse 7df3de9
Merge remote-tracking branch 'origin/feat/delete-package' into dev/pa…
GeckoEidechse fb8cfbf
Merge remote-tracking branch 'origin/feat/install-packages' into dev/…
GeckoEidechse 5fc6669
Merge remote-tracking branch 'origin/feat/upgrade-to-packges' into de…
GeckoEidechse 9f9c555
feat: Support deleting older versions of package
GeckoEidechse 8a1c8d3
fix: Typo in comment
GeckoEidechse ea74685
fix: Add missing semi colon
GeckoEidechse 6958580
feat: Delete packages installed in legacy mode
GeckoEidechse 349a3cb
fix: Remove unnecessary reference
GeckoEidechse a2b80ef
Merge branch 'main' into feat/read-packages-dir
GeckoEidechse f8d321a
Merge remote-tracking branch 'origin/feat/read-packages-dir' into dev…
GeckoEidechse 794817d
Merge branch 'main' into dev/packages
GeckoEidechse 48bfce1
feat: Add ability to delete a Thunderstore package
GeckoEidechse 0d06d88
fix: Remove debug prints
GeckoEidechse 28c2627
Merge branch 'feat/delete-package' into dev/packages
GeckoEidechse 56ac4a1
Merge branch 'main' into dev/packages
GeckoEidechse e0aab46
fix: Typo in comment
GeckoEidechse 5f3dcde
Merge branch 'main' into feat/install-packages
GeckoEidechse e3c68e1
fix: Typo in Cargo.toml
GeckoEidechse 8ae71ef
feat: Delete old version of package on update
GeckoEidechse c16ff2e
chore: Sync with other branch
GeckoEidechse d335e74
feat: Add sanity check for package install
GeckoEidechse ef088ee
Merge branch 'feat/install-packages' into dev/packages
GeckoEidechse c5bffe6
fix: Remove accidentally duplicated code
GeckoEidechse 06cdb5d
Bump libthermite to 0.7.0-alpha.1
GeckoEidechse 68892a4
fix: Formatting
GeckoEidechse d7fdbf8
fix: Bump libthermite to 0.7.0-beta
GeckoEidechse 448c6f3
docs: Add comment explaining "legacy package"
GeckoEidechse e4f995b
docs: Add comment explaining why we skip a folder
GeckoEidechse 17d6282
Merge branch 'main' into dev/packages
GeckoEidechse 5e988a6
style: Remove trailing whitespace
GeckoEidechse 4fbb3e2
Merge branch 'feat/install-packages' into dev/packages
GeckoEidechse 09f8834
Merge branch 'main' into dev/packages
GeckoEidechse 6b49af5
Merge branch 'main' into dev/packages
GeckoEidechse File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps just move this into the match case above ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't I have to duplicate the code then? Cause the
match
matches for like two casesmods.json
manifest.json
and athunderstore_author.txt