Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run linkcheck on push #239

Merged
merged 10 commits into from
Oct 19, 2023
Merged

Run linkcheck on push #239

merged 10 commits into from
Oct 19, 2023

Conversation

GeckoEidechse
Copy link
Member

@GeckoEidechse GeckoEidechse commented Oct 11, 2023

Checks whether any links in markdown files in a push or pull request are broken to prevent cases like #229, #219, #192, #191, #182, #176, #153, #145, #93, and #81

Note that this currently uses https://github.com/gaurav-nelson/github-action-markdown-link-check and NOT https://github.com/Michael-F-Bryan/mdbook-linkcheck

This one seems more popular
help.ea.com seems to filter requests from GitHub causing the action to
think that the link is dead.
config file

help.ea.com seems to filter requests from GitHub causing the action to
think that the link is dead.
They seem to have never worked in the first place
@GeckoEidechse
Copy link
Member Author

Aight, this is working as it should now :D

@GeckoEidechse GeckoEidechse marked this pull request as ready for review October 19, 2023 14:06
@itscynxx
Copy link
Contributor

The links do be checkin

Seems to work, past commits that were meant to make it fail seemed to, maybe we'll finally stop having broken links for months at a time now lol

We even get to exempt links which is nice

Heavily in favor of this being merged

@GeckoEidechse GeckoEidechse merged commit 3d3ca19 into main Oct 19, 2023
2 checks passed
@GeckoEidechse GeckoEidechse deleted the add-linkcheck-ci branch October 19, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants